Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding Embedding Apps Functionality #18566

Merged
merged 7 commits into from
Dec 5, 2022
Merged

Conversation

NilanshBansal
Copy link
Contributor

Description

This PR implements the functionality for Embedding Appsmith apps into any other platform.

It reuses the following existing APIs:

  • /api/v1/applications/{applicationId} (PUT)
  • /api/v1/pages?pageId= (GET)

An additional field embedSetting has been added to the application collection.

Fixes #18292

Job stories

When I build an appsmith app, I want it to embed the app on another platform , so I can add new functionality to existing tools.

When I embed an appsmith app, I want to easily configure the properties for embedding , so I can know all options available to me, and set it up as I please

When I embed an appsmith app, I want it to have a visual interface to configure the embedded app, so I can do it without having to rely on documentation or outside resources

When I embed an app, I want it to communicate with the platform it is embedded in , so I can leverage existing workflows/functionality of other tools, and enhance them using appsmith

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Manual

Testing Results

Postman testing results attached below

Update EmbedSetting API

image

  • Database Record

image

GET EmbedSetting API

image

Checklist:

Dev activity

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • PR is being merged under a feature flag

QA activity:

  • Test plan has been approved by relevant developers
  • Test plan has been peer reviewed by QA
  • Cypress test cases have been added and approved by either SDET or manual QA
  • Organized project review call with relevant stakeholders after Round 1/2 of QA
  • Added Test Plan Approved label after reviewing all Cypress test

@vercel
Copy link

vercel bot commented Nov 29, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview Dec 4, 2022 at 2:28PM (UTC)

@github-actions github-actions bot added Embedding Apps Product Issues related to embedding IDE Pod Issues that new developers face while exploring the IDE labels Nov 29, 2022
@NilanshBansal
Copy link
Contributor Author

/ok-to-test sha=7934ec3dfe0be9a8ea4d2c4ef3828c0b0fa6e0ae

@github-actions
Copy link

github-actions bot commented Dec 1, 2022

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3591903489.
Workflow: Appsmith External Integration Test Workflow.
Commit: 7934ec3dfe0be9a8ea4d2c4ef3828c0b0fa6e0ae.
PR: 18566.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18566&runId=3591903489_1

@NilanshBansal NilanshBansal enabled auto-merge (squash) December 1, 2022 11:04
@NilanshBansal
Copy link
Contributor Author

/ok-to-test sha=6580480614573558a6e41e61c9b8225c0aa476b8

1 similar comment
@NilanshBansal
Copy link
Contributor Author

/ok-to-test sha=6580480614573558a6e41e61c9b8225c0aa476b8

@github-actions
Copy link

github-actions bot commented Dec 2, 2022

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3600707958.
Workflow: Appsmith External Integration Test Workflow.
Commit: 6580480614573558a6e41e61c9b8225c0aa476b8.
PR: 18566.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18566&runId=3600707958_1

@github-actions
Copy link

github-actions bot commented Dec 2, 2022

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3601171453.
Workflow: Appsmith External Integration Test Workflow.
Commit: 6580480614573558a6e41e61c9b8225c0aa476b8.
PR: 18566.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18566&runId=3601171453_1

@NilanshBansal
Copy link
Contributor Author

/ok-to-test sha=26abea8e0bf267c5fbb6e6f74d7395b99ce6adc2

@github-actions
Copy link

github-actions bot commented Dec 4, 2022

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3614355555.
Workflow: Appsmith External Integration Test Workflow.
Commit: 26abea8e0bf267c5fbb6e6f74d7395b99ce6adc2.
PR: 18566.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18566&runId=3614355555_1

@mohanarpit mohanarpit merged commit ebadab5 into release Dec 5, 2022
@mohanarpit mohanarpit deleted the feat/embed-setting branch December 5, 2022 10:19
tanvibhakta added a commit that referenced this pull request Dec 6, 2022
* replace BlackAuthCardNavLink with Link from design system

* Replace AuthCardNavLink with Link from design system

* Refactor ForgotPasswordLink to use Link from design-system

* use variables from ads

* replace FooterLinks with Link

* bump design-system alpha version

* fix issue with Segment header props

* Add font size for ForgotPassword explicitly

* bump alpha version

* Make "Sign In" text primary as well

* Update ds alpha version

* use TextType in location

* use typography constants from design-system

* update alpha version

* bump design-system version

* Empty-Commit

* use correct typographic variables

* fix: Form message component link issue

* removed the inverted flag for testing

* Update to use correct variable

* Change floatingBtn in DefaultTheme file

* fix: Made changes to pass action link element to design system component - formMessage

* chore: update design-system version to fix issue with radio

* Remove unnecessary imports

* fix Merge_spec.js cypress test

* fixed conflict with react router Link and design system Link

* chore: dependentbot vulnerabilities. (#18528)

* fix: dependentbot vulnerabilities.

* chore: remove emoji-mart.

* chore: updated react-syntax-highlighter

* chore: update ts-loader add loader-utils resolution.

Co-authored-by: Aishwarya UR <[email protected]>

* fix:  Added support for country code flags on windows devices (#18203)

* fix: add pollyfill and use font family.

* fix: use latest version design system.

Co-authored-by: Aishwarya UR <[email protected]>

* fix: Updating spec for member roles (#18657)

updated spec for member roles

* feat: [Context Switching] Maintain datasource collapse state (#17616)

* chore: Remove debugging logs for analytics (#18662)

* chore: Support using custom port(s) for listening in the start-https.sh script (#18451)

Added `--https-port` and `--http-port`, so you can set a custom port instead of the default 80 and 443. This is useful if you want to test Appsmith when using a non-standard port, fox example, how `appsmith.URL.host` behaves, or how OAuth redirects behave etc.

We also add a shortcut to start this with release endpoint. Just using `release` is now the same thing as using `https://release.app.appsmith.com`. This is useful to people like me who are _very_ good with typos.

* feat: Adding Embedding Apps Functionality in the API (#18566)

* chore: fix ingress fieldname in appsmith (#18684)

* fix: Auto height breaks for fixed modal's children (#18691)

Fix issue where auto height was throwing an error when a fixed modal widget's children were changing height automatically

* fix: datasource autosave git issue fixed (#18690)

* datasource autosave git issue fixed

* Added appropriate comments

Co-authored-by: “sneha122” <“[email protected]”>

* chore: Improved metadata on logs when reading DSL fails (#18692)

* chore: Improved metadata on logs when reading DSL fails

* Fixed test

* Test fix

* Review comment

* Update top contributors

* chore: bump ds version to use better MenuDivider type

Co-authored-by: Albin <[email protected]>
Co-authored-by: Parthvi Goswami <[email protected]>
Co-authored-by: Arsalan Yaldram <[email protected]>
Co-authored-by: Aishwarya UR <[email protected]>
Co-authored-by: Ankita Kinger <[email protected]>
Co-authored-by: akash-codemonk <[email protected]>
Co-authored-by: Anagh Hegde <[email protected]>
Co-authored-by: Shrikant Sharat Kandula <[email protected]>
Co-authored-by: Nilansh Bansal <[email protected]>
Co-authored-by: Goutham Pratapa <[email protected]>
Co-authored-by: Abhinav Jha <[email protected]>
Co-authored-by: sneha122 <[email protected]>
Co-authored-by: “sneha122” <“[email protected]”>
Co-authored-by: Nidhi <[email protected]>
Co-authored-by: Appsmith Bot <[email protected]>
@Nikhil-Nandagopal Nikhil-Nandagopal added Artifact Platform Product Issues related to the application platform and removed IDE Pod Issues that new developers face while exploring the IDE labels Aug 5, 2024
Copy link
Contributor

coderabbitai bot commented Aug 5, 2024

Warning

Rate limit exceeded

@Nikhil-Nandagopal has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 29 minutes and 55 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 8c6dccb and 26abea8.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Nikhil-Nandagopal Nikhil-Nandagopal added IDE Pod Issues that new developers face while exploring the IDE and removed Artifact Platform Product Issues related to the application platform labels Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Embedding Apps Product Issues related to embedding IDE Pod Issues that new developers face while exploring the IDE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] In-app embed settings
4 participants