fix: Refactor entities based on AST parsing logic

[nidhi-nair]

Description

As a result of this PR, incorrectly refactored references to other entities (widgets, actions, JS objects, JS functions) like when the same string happened to be in a comment, a nested path, a string or any other invalid reference, will now be ignored during refactors. This eliminates another source of possible cyclic dependency errors in Appsmith apps.

Fixes #17047
Fixes #17564
Fixes #17556
Fixes #18493
Fixes #18492
Fixes #18699

Waiting on:

Type of change

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

• Manual

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• PR is being merged under a feature flag

QA activity:

• Test plan has been approved by relevant developers
• Test plan has been peer reviewed by QA
• Cypress test cases have been added and approved by either SDET or manual QA
• Organized project review call with relevant stakeholders after Round 1/2 of QA
• Added Test Plan Approved label after reveiwing all Cypress test

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
appsmith	✅ Ready (Inspect)	Visit Preview	Dec 7, 2022 at 6:18AM (UTC)

[subrata71]

The changes look good to me.

[nidhi-nair]

/ok-to-test sha=b5a0496

[github-actions]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3636215574.
Workflow: Appsmith External Integration Test Workflow.
Commit: b5a0496.
PR: 18517.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18517&runId=3636215574_1

[btsgh]

1. With new line characters, when refactoring happens, the curly braces lose their dark blue color

Raised a separate bug to track this

2. Another issue found in the API value area. - Discussed with @nidhi-nair - not related to entity refactoring - Note - logged this issue for the same

3. Here is a behavior which is inconsistent when a binding is referenced inside a comment. Treating this as acceptable behavior as per this slack thread - @nidhi-nair

4. Here is another issue found. Shared it with @nidhi-nair .. was asked to raise a separate issue

Issue 1 and 4 are the ones that need to be looked into.
Have completed my round of testing.

Testsmith link

5. Also - The Performance link that was shared , for this particular PR, shows up a lot of red values in the SD column. Do get this checked.

[nidhi-nair]

/ok-to-test sha=bab7186

[github-actions]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3639509097.
Workflow: Appsmith External Integration Test Workflow.
Commit: bab7186.
PR: 18517.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18517&runId=3639509097_1

[nidhi-nair]

/perf-test sha=bab7186

[github-actions]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3648592718.
Workflow: Performance Tests Workflow.
Commit: bab7186.
PR: 18517.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18517&runId=3648592718_1

[nidhi-nair]

/perf-test

[github-actions]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3649355355.
Workflow: Performance Tests Workflow.
Commit: ``.
PR: 18517.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18517&runId=3649355355_1

[nidhi-nair]

/perf-test

[github-actions]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3655467511.
Workflow: Performance Tests Workflow.
Commit: ``.
PR: 18517.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18517&runId=3655467511_1

[btsgh]

With 3 open issues around this which will be handled later -

1. [Bug]: The binding reference from a JSObject to a widget still shows an error and the linting value is incorrect #18723
2. [Bug]: API Endpoint, when bound to a widget, on renaming the widget, the name in the endpoint binding does not change #18795
3. [Bug]: When new line characters are used within binding, after refactoring, the braces lose their color #18813

Moving the status to Done

[ChandanBalajiBP]

/perf-test

[github-actions]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3657330043.
Workflow: Performance Tests Workflow.
Commit: ``.
PR: 18517.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18517&runId=3657330043_1

[ChandanBalajiBP]

/perf-test

[github-actions]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3658245000.
Workflow: Performance Tests Workflow.
Commit: ``.
PR: 18517.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18517&runId=3658245000_1

[coderabbitai]

Warning

Rate limit exceeded

@github-actions[bot] has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 4 minutes and 32 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 166414b and bab7186.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.