Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Allow env API for frame ancestors variable #16765

Merged
merged 1 commit into from
Sep 16, 2022

Conversation

sharat87
Copy link
Member

@sharat87 sharat87 commented Sep 14, 2022

Fixes #16597

Summary by CodeRabbit

  • New Features

    • Introduced a new environment variable, APPSMITH_ALLOWED_FRAME_ANCESTORS, enhancing security settings for application deployment by controlling which origins can embed content.
  • Impact

    • This addition bolsters defenses against clickjacking attacks while providing more configuration options for users.

@sharat87 sharat87 added skip-docs skip-changelog Adding this label to a PR prevents it from being listed in the changelog labels Sep 14, 2022
@vercel
Copy link

vercel bot commented Sep 14, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview Sep 14, 2022 at 2:18PM (UTC)

@github-actions github-actions bot added Widgets Product This label groups issues related to widgets Backend This marks the issue or pull request to reference server code Embedding Apps Product Issues related to embedding Task A simple Todo labels Sep 14, 2022
@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@sharat87 sharat87 merged commit c3ac06c into release Sep 16, 2022
@sharat87 sharat87 deleted the chore/allow-frame-ancestors-env-api branch September 16, 2022 07:37
@Nikhil-Nandagopal Nikhil-Nandagopal added Artifact Platform Product Issues related to the application platform and removed Widgets Product This label groups issues related to widgets labels Aug 5, 2024
Copy link
Contributor

coderabbitai bot commented Aug 5, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The recent change introduces a new enumeration constant, APPSMITH_ALLOWED_FRAME_ANCESTORS, to enhance the application's environment variable configurations. This addition aims to improve security by allowing the application to specify which origins can embed its content, addressing potential vulnerabilities related to clickjacking. The change does not disrupt existing functionality but offers a new option for deployment and runtime settings.

Changes

Files Change Summary
.../EnvVariables.java Added new enum constant APPSMITH_ALLOWED_FRAME_ANCESTORS to support security settings for frame ancestors.

Assessment against linked issues

Objective Addressed Explanation
Support APPSMITH_ALLOWED_FRAME_ANCESTORS field in save admin settings API (#16597)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Nikhil-Nandagopal Nikhil-Nandagopal added IDE Pod Issues that new developers face while exploring the IDE and removed Artifact Platform Product Issues related to the application platform labels Aug 6, 2024
Copy link

github-actions bot commented Aug 6, 2024

Unable to find test scripts. Please add necessary tests to the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend This marks the issue or pull request to reference server code Embedding Apps Product Issues related to embedding IDE Pod Issues that new developers face while exploring the IDE skip-changelog Adding this label to a PR prevents it from being listed in the changelog skip-docs Task A simple Todo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Support APPSMITH_ALLOWED_FRAME_ANCESTORS field in save admin settings api
3 participants