feat: ast mono repo poc #15610

AmanAgarwal041 · 2022-08-02T06:47:35Z

POC for Shared AST Logic using Yarn Symlinks

We have added Shared Module Readme to specify the steps to add a shared module, install a shared module in any application within our repo or verify the installation of shared module in any application.

Fixes #15361

Type of change

New feature (non-breaking change which adds functionality)
This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce.
Please also list any relevant details for your test configuration.

Test A
Test B

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes

…smith into feat/ast-symlink

vercel · 2022-08-02T06:47:41Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
appsmith	✅ Ready (Inspect)	Visit Preview	Aug 8, 2022 at 10:39AM (UTC)

vercel · 2022-08-02T10:36:22Z

Deployment failed with the following error:

Resource is limited - try again in 18 minutes (more than 100, code: "api-deployments-free-per-day").

Irongade · 2022-08-04T10:18:46Z

/ok-to-test sha=41efd88

github-actions · 2022-08-04T10:19:26Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2795905469.
Workflow: Appsmith External Integration Test Workflow.
Commit: 41efd88.
PR: 15610.

Irongade · 2022-08-05T15:15:08Z

/ok-to-test sha=b27a7c6

github-actions · 2022-08-05T15:15:43Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2804526808.
Workflow: Appsmith External Integration Test Workflow.
Commit: b27a7c6.
PR: 15610.

github-actions · 2022-08-05T16:04:11Z

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2804526808.
Commit: b27a7c6.
Results:

Click to view performance test results

	Run 1	Run 2	Run 3	Run 4	Run 5	Median	Mean	SD.Sample	SD.Population
SELECT_WIDGET_MENU_OPEN
scripting	1102.28	1142.48	1106.99	1220.45	1175.19	1142.48	1149.48	4.30	3.85
painting	6.61	15.74	7.82	10.5	16.06	10.5	11.35	38.68	34.63
rendering	858.2	873.9	890.13	941.25	921.74	890.13	897.04	3.80	3.40
SELECT_WIDGET_SELECT_OPTION
scripting	157.6	166.08	168.83	168.36	163.87	166.08	164.95	2.76	2.47
painting	6.65	2.92	7.95	3.68	4.57	4.57	5.15	40.78	36.31
rendering	312.49	308.92	327.65	325.85	316.6	316.6	318.3	2.58	2.31

github-actions · 2022-08-08T10:44:56Z

Unable to find test scripts. Please add necessary tests to the PR.

github-actions · 2022-08-08T10:46:23Z

Unable to find test scripts. Please add necessary tests to the PR.

AmanAgarwal041 · 2022-08-08T10:49:57Z

/ok-to-test sha=9c67967

github-actions · 2022-08-08T10:50:30Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2817322970.
Workflow: Appsmith External Integration Test Workflow.
Commit: 9c67967.
PR: 15610.

github-actions · 2022-08-08T11:39:38Z

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2817322970.
Commit: 9c67967.
Results:

Click to view performance test results

	Run 1	Run 2	Run 3	Run 4	Run 5	Median	Mean	SD.Sample	SD.Population
SELECT_WIDGET_MENU_OPEN
scripting	1203.82	1111.48	1061.07	1127.82	1060.05	1111.48	1112.85	5.31	4.75
painting	14.52	5.16	4.66	7.41	9.82	7.41	8.31	48.50	43.32
rendering	873.82	843.25	823.57	860.47	825.86	843.25	845.39	2.58	2.30
SELECT_WIDGET_SELECT_OPTION
scripting	167.75	170.48	153.81	168	161.9	167.75	164.39	4.08	3.64
painting	5.07	4.65	2.36	3.2	5.35	4.65	4.13	31.23	27.85
rendering	318.82	306.02	303.16	291.14	297.77	303.16	303.38	3.40	3.05

Aishwarya-U-R · 2022-08-11T13:48:35Z

Adding 'Test Plan Approved' since this PR is a poc & regression run is suffice as per discussion with @AmanAgarwal041 too.

coderabbitai · 2024-08-05T19:19:22Z

Warning

Rate limit exceeded

@Nikhil-Nandagopal has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 9 minutes and 27 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 901749d and 9c67967.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

Irongade and others added 5 commits July 27, 2022 15:27

POC for Shared AST Logic using Yarn Symlinks

18e8835

fix: preinstall script for bundling shared packages

03a2452

Merge commit

3d368b6

Merge branch 'feat/ast-symlink' of https://github.com/appsmithorg/app…

6047a36

…smith into feat/ast-symlink

fix: updated the script to link, unlink the package as shared dep

c104dd9

fix: updated dependencies

d20ea16

AmanAgarwal041 marked this pull request as draft August 2, 2022 07:59

vercel bot had a problem deploying to Preview – appsmith August 2, 2022 07:59 Failure

Add a post-install script and fix yarn.lock file

41efd88

vercel bot deployed to Preview – appsmith August 2, 2022 10:37 View deployment

Irongade requested review from mohanarpit and sharat87 August 4, 2022 10:17

Remove commented code

b27a7c6

github-actions bot added the AST-frontend Issues related to maintaining AST logic label Aug 5, 2022

vercel bot deployed to Preview – appsmith August 5, 2022 15:13 View deployment

fix: added verification script, readme, moved scripts to shared

9c67967

vercel bot deployed to Preview – appsmith August 8, 2022 10:35 View deployment

AmanAgarwal041 marked this pull request as ready for review August 8, 2022 10:39

github-actions bot added the Enhancement New feature or request label Aug 8, 2022

Irongade requested review from ApekshaBhosale, arunvjn, ohansFavour and rishabhrathod01 and removed request for sharat87 and mohanarpit August 10, 2022 10:14

ApekshaBhosale approved these changes Aug 11, 2022

View reviewed changes

Aishwarya-U-R added the Test Plan Approved Manual/Cypress tests covers changes made on the PR. Else, add skip-testPlan label if not applicable label Aug 11, 2022

AmanAgarwal041 merged commit 3b00508 into release Aug 11, 2022

AmanAgarwal041 deleted the feat/ast branch August 11, 2022 15:29

Nikhil-Nandagopal added the Javascript Product Issues related to users writing javascript in appsmith label Aug 5, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: ast mono repo poc #15610

feat: ast mono repo poc #15610

AmanAgarwal041 commented Aug 2, 2022 •

edited

Loading

vercel bot commented Aug 2, 2022 •

edited

Loading

vercel bot commented Aug 2, 2022

Irongade commented Aug 4, 2022

github-actions bot commented Aug 4, 2022

Irongade commented Aug 5, 2022

github-actions bot commented Aug 5, 2022

github-actions bot commented Aug 5, 2022

github-actions bot commented Aug 8, 2022

github-actions bot commented Aug 8, 2022

AmanAgarwal041 commented Aug 8, 2022

github-actions bot commented Aug 8, 2022

github-actions bot commented Aug 8, 2022

Aishwarya-U-R commented Aug 11, 2022

coderabbitai bot commented Aug 5, 2024

Rate limit exceeded

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

feat: ast mono repo poc #15610

feat: ast mono repo poc #15610

Conversation

AmanAgarwal041 commented Aug 2, 2022 • edited Loading

Type of change

How Has This Been Tested?

Checklist:

vercel bot commented Aug 2, 2022 • edited Loading

vercel bot commented Aug 2, 2022

Irongade commented Aug 4, 2022

github-actions bot commented Aug 4, 2022

Irongade commented Aug 5, 2022

github-actions bot commented Aug 5, 2022

github-actions bot commented Aug 5, 2022

github-actions bot commented Aug 8, 2022

github-actions bot commented Aug 8, 2022

AmanAgarwal041 commented Aug 8, 2022

github-actions bot commented Aug 8, 2022

github-actions bot commented Aug 8, 2022

Aishwarya-U-R commented Aug 11, 2022

coderabbitai bot commented Aug 5, 2024

Rate limit exceeded

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

AmanAgarwal041 commented Aug 2, 2022 •

edited

Loading

vercel bot commented Aug 2, 2022 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)