fix: Popover in Multi select widget inside modals breaks away from the widget #13129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e widget -- Sets popover container to the closest canvas
wmdev0808
added
Bug
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
Medium
|
/ok-to-test sha=43ca423 |
|
Unable to find test scripts. Please add necessary tests to the PR. |
|
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2194713642. |
|
UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2194713642. Click to view performance test results
|
Tooluloope
suggested changes
Apr 20, 2022
Comment on lines
149
to
153
| const node = _menu.current; | ||
| if (Boolean(node?.closest(`.${MODAL_PORTAL_CLASSNAME}`))) { | ||
| return document.querySelector( | ||
| `.${MODAL_PORTAL_CLASSNAME}`, | ||
| ) as HTMLElement; | ||
| } | ||
| return document.querySelector(`.${CANVAS_CLASSNAME}`) as HTMLElement; | ||
| return node?.closest( | ||
| `${SELECT_DROPDOWN_CONTAINER_SELECTOR}`, | ||
| ) as HTMLElement; | ||
| }, []); |
There was a problem hiding this comment.
Can we make getting the Closest canvas widget into a utility function rather than repeating this across
…e widget -- Makes getDropdownPosition as a widget utility function
…e widget -- Rename getDropdownPosition to getCloesetCanvas
|
/ok-to-test sha=0771f23 |
|
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2195755869. |
|
UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2195755869. Click to view performance test results
|
Tooluloope
previously approved these changes
Apr 21, 2022
|
Seems like related tests are failing, Please check @Tooluloope |
|
/ok-to-test sha=7ab05c4 |
|
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2531769549. |
|
UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2531769549. Click to view performance test results
|
|
/ok-to-test sha=5af2839 |
|
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2535378603. |
|
UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2535378603. Click to view performance test results
|
|
/ok-to-test sha=31f91f6 |
|
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2539059851. |
|
UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2539059851. Click to view performance test results
|
|
/ok-to-test sha=43ecd36 |
|
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2539327948. |
|
UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2539327948. Click to view performance test results
|
Tooluloope
approved these changes
Jun 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When I add a multi-select inside a modal with options exceeding the height to see a scroll. After reaching the end of the scroll the multi-select popover breaks away from the modal.
Fixes #12161
Fixes #11485
Type of change
How Has This Been Tested?
Checklist:
Test coverage results 🧪
🟢 Total coverage has increased