Skip to content

Commit

Permalink
test: common code change for Workflow tests (#35886)
Browse files Browse the repository at this point in the history
/ok-to-test tags="@tag.All"



<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10589609542>
> Commit: 27a5564
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10589609542&attempt=3"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Wed, 28 Aug 2024 05:53:34 UTC
<!-- end of auto-generated comment: Cypress test results  -->


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Enhanced user interface functionality by ensuring the application
waits for the button spinner to disappear before proceeding with
visibility assertions and onboarding.
  
- **Improvements**
- Improved user experience by reducing potential inconsistencies or
errors during the onboarding process.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: NandanAnantharamu <[email protected]>
  • Loading branch information
NandanAnantharamu and nandan-nz authored Aug 28, 2024
1 parent c567b13 commit eec7b74
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions app/client/cypress/support/Pages/HomePage.ts
Original file line number Diff line number Diff line change
Expand Up @@ -306,6 +306,7 @@ export class HomePage {
this.agHelper.GetNClick(this._newButtonCreateApplication, 0, true);
this.AssertApplicationCreated();
if (skipSignposting) {
this.agHelper.WaitUntilEleDisappear(this.locator._btnSpinner);
AppSidebar.assertVisible();
this.agHelper.AssertElementVisibility(PageLeftPane.locators.selector);
this.onboarding.skipSignposting();
Expand Down

0 comments on commit eec7b74

Please sign in to comment.