Skip to content

Commit

Permalink
chore: fix ListV2_PageNo_PageSize_spec flakiness (#31979)
Browse files Browse the repository at this point in the history
## Automation

/ok-to-test tags="@tag.List"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!IMPORTANT]  
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/8385766733>
> Commit: `d9a13cf051614a9a68c38624bcaa031f2014df6b`
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8385766733&attempt=2"
target="_blank">Click here!</a>
> All cypress tests have passed 🎉🎉🎉

<!-- end of auto-generated comment: Cypress test results  -->




<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Tests**
- Updated how data is loaded in tests for ListV2 widget to enhance
testing efficiency.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
  • Loading branch information
sbalaji1192 authored Mar 22, 2024
1 parent cf27389 commit 7643b6e
Showing 1 changed file with 1 addition and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import EditorNavigation, {
EntityType,
} from "../../../../../support/Pages/EditorNavigation";

const dslWithServerSide = require("../../../../../fixtures/Listv2/listWithServerSideData.json");
const commonlocators = require("../../../../../locators/commonlocators.json");
const queryLocators = require("../../../../../locators/QueryEditor.json");

Expand Down Expand Up @@ -161,7 +160,7 @@ describe(
});

it("3. should reset page no if higher than max when switched from server side to client side", () => {
cy.addDsl(dslWithServerSide);
_.agHelper.AddDsl("Listv2/listWithServerSideData");
// Open Datasource editor
cy.wait(2000);
_.dataSources.CreateDataSource("Postgres");
Expand Down

0 comments on commit 7643b6e

Please sign in to comment.