Skip to content

Commit

Permalink
fix: fix alignments with the non super user form (#24114)
Browse files Browse the repository at this point in the history
## Description
fixes alignments with the non super user form.

#### PR fixes following issue(s)
Fixes #24106 
#### Media

![image](https://github.com/appsmithorg/appsmith/assets/26247571/39659c7b-943b-45db-b0ad-a98a098421ef)

![image](https://github.com/appsmithorg/appsmith/assets/26247571/64dc8b39-3295-4c8f-a20c-2fc5bc0f056c)


#### Type of change
- Bug fix (non-breaking change which fixes an issue)
>
>
## Testing
>
#### How Has This Been Tested?
- [x] Manual
- [ ] Jest
- [ ] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Test-plan-implementation#speedbreaker-features-to-consider-for-every-change)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans/_edit#areas-of-interest)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
  • Loading branch information
dipyamanbiswas07 authored Jun 6, 2023
1 parent 2c9fc11 commit 297eb69
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
4 changes: 3 additions & 1 deletion app/client/src/pages/setup/GetStarted.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ export function SuperUserForm() {

const StyledNonSuperUserForm = styled.form`
width: 400px;
margin-right: 3rem;
`;

const Space = styled.div`
Expand Down Expand Up @@ -117,10 +118,11 @@ function NonSuperUser(
</DropdownWrapper>
<ActionContainer>
<StyledButton
className="t--get-started-button"
className="w-full t--get-started-button"
isDisabled={props.invalid}
kind="primary"
renderAs="button"
size={"md"}
type="submit"
>
{createMessage(WELCOME_ACTION)}
Expand Down
5 changes: 3 additions & 2 deletions app/client/src/pages/setup/Welcome.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -43,16 +43,17 @@ const StyledBannerHeader = styled.div`
font-size: 72px;
margin: 0px 0px;
font-weight: 600;
margin-right: 1rem;
margin-right: 3rem;
width: 100%;
text-align: center;
color: var(--ads-v2-color-fg-emphasis-plus);
`;

const StyledBannerBody = styled.div`
font-size: 24px;
margin: ${(props) => props.theme.spaces[7]}px 0px;
font-weight: 500;
margin-right: 8rem;
margin-right: 9rem;
width: 100%;
text-align: center;
color: var(--ads-v2-color-fg);
Expand Down

0 comments on commit 297eb69

Please sign in to comment.