Skip to content

Commit

Permalink
check settings render issue
Browse files Browse the repository at this point in the history
  • Loading branch information
hetunandu committed Oct 8, 2024
1 parent d1da237 commit 14517e9
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 5 deletions.
2 changes: 1 addition & 1 deletion app/client/cypress/support/Pages/DataSources.ts
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ export class DataSources {
".t--datasource-name:contains('" + dsName + "')";
_mandatoryMark = "//span[text()='*']";
_deleteDSHostPort = ".t--delete-field";
_dsTabSchema = "[data-testid='t--tab-schema']";
_dsTabSchema = "[data-testid='t--tab-SCHEMA_TAB']";
private _pageSelectionMenu = "[data-testId='t--page-selection']";

private _pageSelectMenuItem = ".ads-v2-menu__menu-item";
Expand Down
17 changes: 13 additions & 4 deletions app/client/src/pages/Editor/ActionSettings.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import FormControl from "./FormControl";
import log from "loglevel";
import type { EditorTheme } from "components/editorComponents/CodeEditor/EditorConfig";
import styled from "styled-components";
import { Text } from "@appsmith/ads";

interface ActionSettingsProps {
// TODO: Fix this the next time the file is edited
Expand All @@ -21,9 +22,11 @@ const ActionSettingsWrapper = styled.div`
width: 100%;
max-width: 600px;
padding-bottom: 1px;
.form-config-top {
flex-grow: 1;
}
.t--form-control-SWITCH {
display: flex;
flex-shrink: 0;
Expand All @@ -35,10 +38,16 @@ const ActionSettingsWrapper = styled.div`
function ActionSettings(props: ActionSettingsProps): JSX.Element {
return (
<ActionSettingsWrapper>
{/* TODO: Fix this the next time the file is edited */}
{/* eslint-disable-next-line @typescript-eslint/no-explicit-any */}
{props.actionSettingsConfig.map((section: any) =>
renderEachConfig(section, props.formName),
{!props.actionSettingsConfig ? (
<Text color="var(--ads-v2-color-fg-error)" kind="heading-m">
Error: No settings config found
</Text>
) : (
/* TODO: Fix this the next time the file is edited */
/* eslint-disable-next-line @typescript-eslint/no-explicit-any */
props.actionSettingsConfig.map((section: any) =>
renderEachConfig(section, props.formName),
)
)}
</ActionSettingsWrapper>
);
Expand Down

0 comments on commit 14517e9

Please sign in to comment.