Rename heartbeats to cron check-ins #957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unflxw
force-pushed
the
rename-heartbeats-to-cron-checkins
branch
2 times, most recently
from
3a32996
to
2e46614
Compare
unflxw
added a commit
to appsignal/appsignal-nodejs
that referenced
this pull request
Jul 11, 2024
See appsignal/appsignal-elixir#957. Emit a deprecation warning both when the `heartbeat` helper is used and when the `Heartbeat` class is initialised, but only once each.
unflxw
added a commit
to appsignal/appsignal-nodejs
that referenced
this pull request
Jul 11, 2024
See appsignal/appsignal-elixir#957. Emit a deprecation warning both when the `heartbeat` helper is used and when the `Heartbeat` class is initialised, but only once each.
unflxw
added a commit
to appsignal/appsignal-nodejs
that referenced
this pull request
Jul 11, 2024
See appsignal/appsignal-elixir#957. Emit a deprecation warning both when the `heartbeat` helper is used and when the `Heartbeat` class is initialised, but only once each.
unflxw
added a commit
to appsignal/appsignal-nodejs
that referenced
this pull request
Jul 12, 2024
See appsignal/appsignal-elixir#957. Emit a deprecation warning both when the `heartbeat` helper is used and when the `Heartbeat` class is initialised, but only once each.
unflxw
added a commit
to appsignal/appsignal-nodejs
that referenced
this pull request
Jul 12, 2024
See appsignal/appsignal-elixir#957. Emit a deprecation warning both when the `heartbeat` helper is used and when the `Heartbeat` class is initialised, but only once each.
unflxw
added a commit
to appsignal/appsignal-nodejs
that referenced
this pull request
Jul 15, 2024
See appsignal/appsignal-elixir#957. Emit a deprecation warning both when the `heartbeat` helper is used and when the `Heartbeat` class is initialised, but only once each.
unflxw
changed the title
unflxw
force-pushed
the
rename-heartbeats-to-cron-checkins
branch
2 times, most recently
from
b784f0c
to
0169f99
Compare
luismiramirez
approved these changes
Aug 6, 2024
jeffkreeftmeijer
approved these changes
Aug 6, 2024
tombruijn
approved these changes
Aug 6, 2024
This comment has been minimized.
This comment has been minimized.
unflxw
added a commit
to appsignal/appsignal-nodejs
that referenced
this pull request
Aug 7, 2024
See appsignal/appsignal-elixir#957. Emit a deprecation warning both when the `heartbeat` helper is used and when the `Heartbeat` class is initialised, but only once each.
See appsignal/appsignal-ruby#1115. Rename the existing heartbeat functionality to cron check-in. To only emit a single deprecation warning at compile-time, rather than many at run-time, use the built-in `@deprecated` Elixir functionality. The deprecation warning is not itself under test, but the forwarding of method calls from the old names to the new names is.
Change the endpoint to `/check_ins/json` and amend the event format to use `identifier` instead of `name`, `digest` instead of `id`, and a new `check_in_type` field.
unflxw
force-pushed
the
rename-heartbeats-to-cron-checkins
branch
from
0169f99
to
4bfff38
Compare
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Use `identifier` and `digest` instead of `name` and `id` respectively.
This comment has been minimized.
This comment has been minimized.
1 similar comment
|
This is a message from the daily scheduled checks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See appsignal/appsignal-ruby#1115.
Rename the existing heartbeat functionality to cron check-in. To only emit a single deprecation warning at compile-time, rather than many at run-time, use the built-in
@deprecatedElixir functionality. The deprecation warning is not itself under test, but the forwarding of method calls from the old names to the new names is.