-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch off master and main versions to fix CI #954
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using OTP master and Elixir main, use "latest" for all linting checks. The version matrix does still include master/main. [skip changeset]
Previously, we tried using the latest version of both Elixir and OTP. Since we're having trouble with hex.pm currently, switch to released versions of both to decrease the reliance on hex.pm. [skip changeset]
The main/master pair was added to the CI to ensure the integration keeps working on to-be-released versions of OTP and Elixir. Currently, most likely because of a change upstream, the CI is failing. This patch replaces the main/master pair with the latest released version of each. [skip changeset]
Since builds.hex.pm produces 404s when fetching these versions (which could be an issue with Hex, or a misunderstanding about the "latest" versions from our side), remove them for now to get the CI to be green again. [skip changeset]
jeffkreeftmeijer
added a commit
that referenced
this pull request
Jul 3, 2024
Removed in #954, this patch restores the Elixir main and Erlang master versions on CI.
jeffkreeftmeijer
added a commit
that referenced
this pull request
Jul 3, 2024
Removed in #954, this patch restores the Elixir main and Erlang master versions on CI. [skip changeset]
Merged
jeffkreeftmeijer
added a commit
to appsignal/appsignal-elixir-phoenix
that referenced
this pull request
Jul 3, 2024
Because of issues building Elixir main on OTP master, replace the main/master pair with 27.x/latest. Related to appsignal/appsignal-elixir#954. [skip changeset]
jeffkreeftmeijer
added a commit
to appsignal/appsignal-elixir-phoenix
that referenced
this pull request
Jul 3, 2024
Because of issues building Elixir main on OTP master, replace the main/master pair with 27.x/latest. Related to appsignal/appsignal-elixir#954. [skip changeset]
jeffkreeftmeijer
added a commit
to appsignal/appsignal-elixir-plug
that referenced
this pull request
Jul 9, 2024
Because of issues building Elixir main on OTP master, replace the main/master pair with 27.x/latest. Related to appsignal/appsignal-elixir#954. [skip changeset]
jeffkreeftmeijer
added a commit
to appsignal/appsignal-elixir-plug
that referenced
this pull request
Jul 9, 2024
Because of issues building Elixir main on OTP master, replace the main/master pair with 27.x/latest. Related to appsignal/appsignal-elixir#954. [skip changeset]
jeffkreeftmeijer
added a commit
that referenced
this pull request
Jul 23, 2024
Removed in #954, this patch restores the Elixir main and Erlang master versions on CI. [skip changeset]
jeffkreeftmeijer
added a commit
that referenced
this pull request
Jul 23, 2024
Removed in #954, this patch restores the Elixir main version on CI. [skip changeset]
jeffkreeftmeijer
added a commit
that referenced
this pull request
Jul 23, 2024
Removed in #954, this patch restores the Elixir main version on CI. [skip changeset]
jeffkreeftmeijer
added a commit
that referenced
this pull request
Jul 23, 2024
Removed in #954, this patch restores the Elixir main version on CI. [skip changeset]
jeffkreeftmeijer
added a commit
that referenced
this pull request
Jul 23, 2024
Removed in #954, this patch restores the Elixir main version on CI. [skip changeset]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of build issues, replace the main/master versions from the CI and run on the latest released versions instead.
We'd still want to run the CI on unreleased versions, so a pull request is incoming that puts them back. We can then track that to see if the issues resolve.
[skip changeset]