Ignore binwrite error response handling warning

[luismiramirez]

IO's module binwrite/2 function no longer returns an error touple when
failing. Instead, it raises an Erlang error. This commit makes dialyzer
ignore that warning so it behaves appropriately in newer and older
versions.

[skip changeset]

Ref: https://github.com/elixir-lang/elixir/blob/v1.17.1/lib/elixir/lib/io.ex#L280-L284

[tombruijn]

Sounds like this would break in real apps, wouldn't we want to ship a new version with this?

[luismiramirez]

Sounds like this would break in real apps, wouldn't we want to ship a new version with this?

I'm not too confident with the change because of this, either. In older lang versions wouldn't be a huge break but a silent crash, probably.

What do you think if we avoid Dialyzer checking that line? At the end of the day, it's only an unmatchable pattern warning.

[tombruijn]

If it can never be anything else than an :ok, we can just as well write it like:

:ok = IO.binwrite(file, appsignal_config_file_contents(config))
IO.puts("Success!")

If it raises an error, it would become something like:

try do
  :ok = IO.binwrite(file, appsignal_config_file_contents(config))
  IO.puts("Success!")
rescue
  e -> e
    IO.puts("Failure! #{inspect(e)}")
    exit(:shutdown)
end

[luismiramirez]

It might be an error tuple on older versions. That's why maybe it's more sensible to skip the linter.

[backlog-helper]

• This Pull Request needs more reviews. @jeffkreeftmeijer - (More info)

---

This is a message from the daily scheduled checks.

New issue guide | Backlog management | Rules | Feedback