Merge pull request #952 from appsignal/dialyzer-fixes

Fix Dialyzer warnings and remove ignore file

lib/mix/tasks/appsignal.install.ex

@@ -183,7 +183,7 @@ defmodule Mix.Tasks.Appsignal.Install do
 
     case File.open(appsignal_config_file_path(), [:write]) do
       {:ok, file} ->
-        case IO.binwrite(file, appsignal_config_file_contents(config)) do
+        case binwrite_with_result(file, appsignal_config_file_contents(config)) do
           :ok ->
             IO.puts("Success!")
 
@@ -200,6 +200,18 @@ defmodule Mix.Tasks.Appsignal.Install do
     end
   end
 
+  if Version.match?(System.version(), ">= 1.16.0") do
+    defp binwrite_with_result(path, contents) do
+      try do
+        IO.binwrite(path, contents)
+      catch
+        {:error, reason} -> {:error, reason}
+      end
+    end
+  else
+    defdelegate binwrite_with_result(path, contents), to: IO, as: :binwrite
+  end
+
   # Link the config/appsignal.exs config file to the config/config.exs file.
   # If already linked, it's ignored.
   defp link_config_file do

mix.exs

@@ -37,7 +37,6 @@ defmodule Appsignal.Mixfile do
         extras: ["README.md", "CHANGELOG.md"]
       ],
       dialyzer: [
-        ignore_warnings: "dialyzer.ignore-warnings",
         plt_file: {:no_warn, "priv/plts/dialyzer.plt"},
         plt_add_apps: [:mix]
       ]