Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate work dispatchers into our drivers #211

Merged
merged 2 commits into from
Feb 19, 2025

Conversation

reverendbedford
Copy link
Collaborator

Let users optionally provide a work dispatcher to handle running work through a driver. Default option will still be to pass everything into the model once.

- I guess this is the right logic
- This should handle the negative index batch dimension
- Moved some helper functions out
- Basic idea works, need to argue with gary
- Fork in the road
- Gary jit issue
@hugary1995 hugary1995 force-pushed the integrate_dispatchers branch from 14ff3eb to cffffa7 Compare February 18, 2025 18:59
Copy link
Collaborator

@hugary1995 hugary1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had some really minor comments so I just pushed a few commits to address them. I've also addressed most of my own comments during the rebasing, so technically speaking I'm not an independent reviewer. But nevertheless the changes you made look good to me.

Copy link
Contributor

github-actions bot commented Feb 18, 2025

Documentation preview removed.
To view the documentation, please visit the main documentation page.

@hugary1995 hugary1995 force-pushed the integrate_dispatchers branch from d65c39c to 0585d32 Compare February 19, 2025 01:01
- Fix mandel notation batch generalization
- Link neml2_driver against neml2_dispatcher
- Fix documentation
- Add compile definition to guard dispatcher
@hugary1995 hugary1995 force-pushed the integrate_dispatchers branch from 0585d32 to 7486af5 Compare February 19, 2025 01:04
@reverendbedford reverendbedford merged commit 8d22640 into main Feb 19, 2025
19 checks passed
@reverendbedford reverendbedford deleted the integrate_dispatchers branch February 19, 2025 02:03
github-actions bot added a commit that referenced this pull request Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants