Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change OSL to Version 1.11.9 and LLVM to Version 9 #2902

Closed
wants to merge 8 commits into from
Closed

Change OSL to Version 1.11.9 and LLVM to Version 9 #2902

wants to merge 8 commits into from

Conversation

LZaw
Copy link
Member

@LZaw LZaw commented Nov 16, 2020

Before merging, I still have to update OSL in the Linux and Windows dependency package, to have every OS work on the same (major) version.

@LZaw LZaw added the WIP ⚠ label Nov 16, 2020
@LZaw LZaw added the PR | Squash This PR must be squashed when merged. label Nov 16, 2020
oktomus
oktomus previously approved these changes Dec 5, 2020
View reviewed changes
Copy link
Member

@oktomus oktomus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you ! Can't wait to see that "build fail" on each PR disappear 🤣

@ghost
Copy link

ghost commented Dec 5, 2020

I think the change in #2900 (in the cmake file) should fix the function was not declared errors in osl.

@oktomus oktomus dismissed their stale review December 5, 2020 13:39

Mistake

Mango-3
Mango-3 reviewed Dec 24, 2020
View reviewed changes
Copy link
Member

@Mango-3 Mango-3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line 168 -DWITH_DISNEY_MATERIAL=ON \ should be removed. We don't use the Disney material anymore. It has been removed from the sources with commit 1e8e30c

@LZaw
Copy link
Member Author

LZaw commented Jan 2, 2021

Thank you for the hint.
I removed it, as well as the SeExpr.

@LZaw LZaw closed this Feb 5, 2021
@LZaw LZaw deleted the TravisLLVM9 branch February 5, 2021 15:36
@LZaw LZaw restored the TravisLLVM9 branch February 5, 2021 15:37
@LZaw LZaw reopened this Feb 5, 2021
@LZaw LZaw closed this Feb 5, 2021
@LZaw LZaw deleted the TravisLLVM9 branch February 5, 2021 15:38
@LZaw LZaw restored the TravisLLVM9 branch February 5, 2021 15:39
@LZaw LZaw reopened this Feb 5, 2021
@LZaw LZaw closed this Feb 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mango-3 Mango-3 Mango-3 left review comments

@oktomus oktomus oktomus left review comments

Assignees
No one assigned
Labels
PR | Squash This PR must be squashed when merged. WIP ⚠
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LZaw @oktomus @Mango-3