Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a swift-format check to run on PRs. #1719

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

thomasvl
Copy link
Collaborator

Based off the swift-nio ones.

@thomasvl thomasvl force-pushed the swift-format_check branch 3 times, most recently from 4ddf45c to d66ae2c Compare September 20, 2024 20:29
@thomasvl thomasvl marked this pull request as ready for review September 20, 2024 20:30
@thomasvl
Copy link
Collaborator Author

Confirmed the check works with a edit in one of the pushes: https://github.com/apple/swift-protobuf/actions/runs/10965837593/job/30452496743

And https://github.com/apple/swift-protobuf/actions/runs/10965790445/job/30452355139 shows all the swift format lint warnings for why I disabled that.

@tbkka tbkka requested a review from Lukasa September 20, 2024 20:57
@thomasvl
Copy link
Collaborator Author

@Lukasa gentle ping

Based off the swift-nio ones.
@thomasvl
Copy link
Collaborator Author

All the other PRs that have landed have lint almost passing. The two things that remain would be api breaking and/or seem like bugs in swift-format, so I've upstreamed an issue for the bug (and the fact that suppressions don't seem to work).

@thomasvl
Copy link
Collaborator Author

thomasvl commented Oct 8, 2024

gentle ping

Copy link
Collaborator

@tbkka tbkka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@thomasvl thomasvl merged commit 4782e2f into apple:main Oct 8, 2024
12 checks passed
@thomasvl thomasvl deleted the swift-format_check branch October 8, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants