Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for OperationDescription.responseOutcomes #554

Conversation

mt-hodaka
Copy link
Contributor

Motivation

I couldn't reproduce the issue #530 on my end.
However, I noticed that there were no tests, so I would like to add them.

Modifications

Adding tests.

Result

Only adding tests, no change in the behavior of the library.

Test Plan

Added tests are passing.

@mt-hodaka mt-hodaka marked this pull request as ready for review March 27, 2024 18:10
@simonjbeaumont
Copy link
Collaborator

@swift-server-bot test this please

@simonjbeaumont
Copy link
Collaborator

Weird, we're getting a bunch of failures in our compat suite now, but there's been no change to the project or the OpenAPI documents (which are referenced by Git hash). I wonder if this has been caused by a dependency change somewhere. Possibly related to the discussion going on in #553.

Have opened an empty PR to isolate: #555.

//cc @czechboy0

@czechboy0
Copy link
Collaborator

@swift-server-bot test this please

1 similar comment
@czechboy0
Copy link
Collaborator

@swift-server-bot test this please

Copy link
Collaborator

@czechboy0 czechboy0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@czechboy0 czechboy0 enabled auto-merge (squash) April 16, 2024 10:13
@czechboy0 czechboy0 merged commit f6d37bb into apple:main Apr 16, 2024
9 checks passed
@czechboy0 czechboy0 added semver/patch No public API change. semver/none No version bump required. and removed semver/patch No public API change. labels Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/none No version bump required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants