[GHA] Unacceptable language check #2766

FranzBusch · 2024-07-04T16:20:22Z

Motivation

Next up replacing part of our soundness script that checked for unacceptable language.

Modification

This PR adds a new GH action that checks for unacceptable language.

Result

One more script replaced.

0xTim · 2024-07-04T16:25:21Z

.github/workflows/pull_requests.yml

+        fi
+
+        log "✅ Found no unacceptable language."


Very minor nit - no newline at the end of the file adds a tiny bit of noise to the diff

.github/workflows/pull_requests.yml

.github/workflows/reusable_pull_request.yml

# Motivation Next up replacing part of our soundness script that checked for unacceptable language. # Modification This PR adds a new GH action that checks for unacceptable language. # Result One more script replaced

.github/workflows/reusable_pull_request.yml

IntegrationTests/tests_01_http/defines.sh

NOTICE.txt

glbrntt · 2024-07-08T14:58:36Z

NOTICE.txt


 ---

 This product contains NodeJS's llhttp.

  * LICENSE (MIT):
-    * https://github.com/nodejs/llhttp/blob/master/LICENSE-MIT
+    * https://github.com/nodejs/llhttp/blob/1e1c5b43326494e97cf8244ff57475eb72a1b62c/LICENSE-MIT


This repo switched to main so let's just use that

I disagree. I think using exact sha's is better here since main/master can remove the files.

For license I agree as long as long it aligns with the copy we vendored. For homepage I think it's odd to reference a specific commit, IMO makes more sense to just link to the repo.

NOTICE.txt

glbrntt · 2024-07-08T15:02:21Z

Sources/CNIOSHA1/update_and_patch_sha1.sh

@@ -35,7 +35,7 @@ for f in sha1.c sha1.h; do
      echo "    - use welcoming language (soundness check)"
      echo "    - ensure BYTE_ORDER is defined"
      echo "*/"
-      curl -Ls "https://raw.githubusercontent.com/freebsd/freebsd/master/sys/crypto/$f"
+      curl -Ls "https://raw.githubusercontent.com/freebsd/freebsd/master/sys/crypto/$f" # ignore-unacceptable-language


This switched to main

.github/workflows/reusable_pull_request.yml

simonjbeaumont

Looking really nice. Agree with George's comments and left a couple of nits for consideration.

LGTM though so I'm not gonna mark it as needs changes from my end.

.github/workflows/reusable_pull_request.yml

simonjbeaumont · 2024-07-08T15:23:29Z

.github/workflows/reusable_pull_request.yml

+        done
+
+  acceptable-language-check:


nit: I see this changed from a check for unacceptable language, to a check for acceptable language. IMO that's a stretch...

simonjbeaumont · 2024-07-08T15:26:21Z

scripts/acceptable_language_check.sh

+error() { printf -- "** ERROR: %s\n" "$*" >&2; }
+fatal() { error "$@"; exit 1; }
+
+test -n "${UNACCEPTABLE_LANGUAGE_PATTERNS:-}" || fatal "UNACCEPTABLE_LANGUAGE_PATTERNS unset"


I think this would be clearer as an input to the script if this was UNACCEPTABLE_LANGUAGE_WORDS or similar. The fact that it becomes patterns below is an implementation detail of the fact we're using grep. It would also make the actions yaml clearer IMO.

* apple/main: (26 commits) [GHA] Only format Swift files that are in Git index (apple#2797) Ignore format commit from git blame (apple#2796) Adopt swift-format (apple#2794) Disable warnings as errors on Swift 6 and main (apple#2793) ChannelHandler: provide static (un)wrap(In|Out)bound(In|Out) (apple#2791) Add manual control to NIOLockedValueBox (apple#2786) [GHA] Cxx interoperability compatibility and integration tests check (apple#2790) [GHA] Introduce reusable matrix workflow (apple#2789) Fix benchmark thresholds update script (apple#2783) [GHA] Broken symlink and format check (apple#2787) [GHA] Add license header check (apple#2781) Improved documentation for HTTP Parts to clarify how often each part is received (apple#2775) [GHA] Download the scripts to make workflow reusable (apple#2785) Combine the two NIOAsyncChannel channel handlers (apple#2779) [GHA] Benchmark job (apple#2780) [GHA] Move docs check to script (apple#2776) Add benchmark for creating NIOAsyncChannel (apple#2774) Avoid creating a yield ID counter per async writer (apple#2768) [GHA] Unacceptable language check (apple#2766) Allow in-place mutation of `NIOLoopBoundBox.value` (apple#2771) ... # Conflicts: # Sources/NIOPosix/BSDSocketAPICommon.swift # Sources/NIOPosix/GetaddrinfoResolver.swift # Sources/NIOPosix/HappyEyeballs.swift

FranzBusch added the semver/none No version bump required. label Jul 4, 2024

FranzBusch assigned glbrntt Jul 4, 2024

FranzBusch force-pushed the fb-gha-profanity-check branch from af4ced5 to 904df5c Compare July 4, 2024 16:24

0xTim reviewed Jul 4, 2024

View reviewed changes

simonjbeaumont reviewed Jul 5, 2024

View reviewed changes

.github/workflows/pull_requests.yml Outdated Show resolved Hide resolved

.github/workflows/pull_requests.yml Outdated Show resolved Hide resolved

FranzBusch force-pushed the fb-gha-profanity-check branch from 904df5c to 3f679d7 Compare July 5, 2024 11:27

weissi reviewed Jul 5, 2024

View reviewed changes

.github/workflows/reusable_pull_request.yml Outdated Show resolved Hide resolved

weissi reviewed Jul 5, 2024

View reviewed changes

.github/workflows/reusable_pull_request.yml Outdated Show resolved Hide resolved

FranzBusch force-pushed the fb-gha-profanity-check branch from 3f679d7 to 9109fb6 Compare July 8, 2024 12:52

FranzBusch requested a review from weissi July 8, 2024 14:34

FranzBusch force-pushed the fb-gha-profanity-check branch from 9109fb6 to ed4e124 Compare July 8, 2024 14:34

FranzBusch requested review from simonjbeaumont and glbrntt July 8, 2024 14:34

[GHA] Unacceptable language check

d7d51c3

# Motivation Next up replacing part of our soundness script that checked for unacceptable language. # Modification This PR adds a new GH action that checks for unacceptable language. # Result One more script replaced

FranzBusch force-pushed the fb-gha-profanity-check branch from ed4e124 to d7d51c3 Compare July 8, 2024 14:34

glbrntt requested changes Jul 8, 2024

View reviewed changes

simonjbeaumont reviewed Jul 8, 2024

View reviewed changes

FranzBusch force-pushed the fb-gha-profanity-check branch from 09cc96a to 8b3a0ed Compare July 8, 2024 15:27

PR review

1a22c87

FranzBusch force-pushed the fb-gha-profanity-check branch from 8b3a0ed to 1a22c87 Compare July 8, 2024 15:29

FranzBusch requested review from glbrntt and simonjbeaumont July 8, 2024 15:30

Change homepage link to repo

6fc47fd

FranzBusch enabled auto-merge (squash) July 8, 2024 18:17

glbrntt approved these changes Jul 9, 2024

View reviewed changes

FranzBusch merged commit 5cc0549 into main Jul 9, 2024
16 of 17 checks passed

FranzBusch deleted the fb-gha-profanity-check branch July 9, 2024 06:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[GHA] Unacceptable language check #2766

[GHA] Unacceptable language check #2766

FranzBusch commented Jul 4, 2024

0xTim Jul 4, 2024

glbrntt Jul 8, 2024

FranzBusch Jul 8, 2024

glbrntt Jul 8, 2024

glbrntt Jul 8, 2024

simonjbeaumont left a comment

simonjbeaumont Jul 8, 2024

simonjbeaumont Jul 8, 2024

[GHA] Unacceptable language check #2766

[GHA] Unacceptable language check #2766

Conversation

FranzBusch commented Jul 4, 2024

Motivation

Modification

Result

0xTim Jul 4, 2024

Choose a reason for hiding this comment

glbrntt Jul 8, 2024

Choose a reason for hiding this comment

FranzBusch Jul 8, 2024

Choose a reason for hiding this comment

glbrntt Jul 8, 2024

Choose a reason for hiding this comment

glbrntt Jul 8, 2024

Choose a reason for hiding this comment

simonjbeaumont left a comment

Choose a reason for hiding this comment

simonjbeaumont Jul 8, 2024

Choose a reason for hiding this comment

simonjbeaumont Jul 8, 2024

Choose a reason for hiding this comment