Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ByteBuffer.debugDescription suitable for structural display #2495

Merged
merged 4 commits into from
Sep 9, 2024
Merged

Make ByteBuffer.debugDescription suitable for structural display #2495

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c7813ee
Make `ByteBuffer.debugDescription` suitable for structural display
dnadoba Aug 7, 2023
79bb0f1
Merge branch 'main' into dn-byte-buffer-debug-description
dnadoba Aug 7, 2023
b860d59
Merge branch 'main' into dn-byte-buffer-debug-description
FranzBusch Sep 5, 2024
ea81436
Merge branch 'main' into dn-byte-buffer-debug-description
weissi Sep 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions Sources/NIOCore/ByteBuffer-core.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -971,18 +971,8 @@ extension ByteBuffer: CustomStringConvertible, CustomDebugStringConvertible {
"[\(self.hexDump(format: .compact(maxBytes: 64)))](\(self.readableBytes) bytes)"
}

/// A `String` describing this `ByteBuffer` including length and the bytes it contains (partially).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dnadoba why delete the comment?

///
/// For a `ByteBuffer` initialised with `hello world` the description would be the following:
///
/// [68656c6c6f20776f726c64](11 bytes)
///
/// Buffers larger that 64 bytes will get truncated when printing out.
/// The format of the description is not API.
///
/// - returns: A description of this `ByteBuffer`.
public var debugDescription: String {
"[\(self.hexDump(format: .compact(maxBytes: 64)))](\(self.readableBytes) bytes)"
String(describing: self)
}
}

Expand Down
Loading