Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds a few things needed for a Pnns service. #81

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Adds a few things needed for a Pnns service. #81

merged 1 commit into from
Aug 29, 2024

Conversation

fboemer
Copy link
Contributor

@fboemer fboemer commented Aug 28, 2024

  • SerializedProcessedDatabase deserialization,
  • Query -> proto and back conversion.
  • Make Server sendable
  • Remove PrivateNearestNeighborsSearchProtobuf message save/load extensions (which were causing "Ambiguous use of init(from: errors", sine the same extension is already defined in HomomorphicEncryptionProtobuf
  • A nice to have: some extra ServerConfig methods

@fboemer
Adds a few things needed for a Pnns service.
5220862 
* SerializedProcessedDatabase deserialization,
* Query -> proto and back conversion.
* Make Server sendable
* Remove PrivateNearestNeighborsSearchProtobuf message save/load extensions (which were causing "Ambiguous use of init(from:  errors", sine the same extension is already defined in HomomorphicEncryptionProtobuf
* A nice to have: some extra ServerConfig methods
@fboemer fboemer enabled auto-merge (squash) August 29, 2024 14:32
@fboemer fboemer merged commit f6fc5b0 into main Aug 29, 2024
6 checks passed
@fboemer fboemer deleted the fboemer/deserialized-processed-database branch August 29, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RuiyuZhu RuiyuZhu RuiyuZhu approved these changes

@karulont karulont Awaiting requested review from karulont karulont is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fboemer @RuiyuZhu