Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed WorkerPool to handle remote actors properly #1164

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Fixed WorkerPool to handle remote actors properly #1164

wants to merge 11 commits into from
+449 −125

Conversation

akbashev
Copy link
Contributor

Currently WorkerPool:

  • Treats remote actors as weak and cleans them directly
  • Doesn't work on Swift 6 mode as WorkItem and WorkResult are not marked as Sendable

This PR fixes this, basically cherry picked changes from this PR #1159 and updated tests

@akbashev
wip
b21d000 
wip

wip

strong ref fix
@akbashev akbashev marked this pull request as ready for review October 15, 2024 15:01
@akbashev
Copy link
Contributor Author

Hm, would be nice to add test to check remote actors also.

ktoso
ktoso reviewed Oct 16, 2024
View reviewed changes
Copy link
Member

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just needs to be careful with the enums and maybe add one more test?

@akbashev akbashev requested a review from ktoso November 6, 2024 10:51
@ktoso
Copy link
Member

ktoso commented Nov 6, 2024

@swift-server-bot test this please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktoso ktoso ktoso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akbashev @ktoso