Fix Scheduler implementation for ILP32 platforms such as watchOS #1137
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Scheduler implementation for ILP32 platforms such as watchOS on arm64_32
Motivation:
Fix a bug in the Scheduler where converting the UInt64 nanoseconds value from a
Duration
value to theDispatchTimeInterval
'sInt
associated value causes an uncaught overflow and crash on devices with 32-bit Int values.Modifications:
Add
DispatchTime.init(nowDelayedBy:)
, which computes the deadline and avoids casting toInt
Replace adhoc computations of Scheduler deadline with designated
DispatchTime.init(nowDelayedBy:)
Result:
Prevents crash on ILP32 platforms when time delay exceeds a value that fits within a 32-bit Int