Correct netty dependencies #3078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Maven helped to identify that after apple#3055 generated pom.xml files are invalid. We forgot to include `netty-bom` in some modules that depend on `io.netty` without specifying netty version. Also, noticed that some of our modules that use `io.netty` do not list all used netty dependencies as needed. Modifications: - For all modules that contain `-netty` in their names add missed `netty-bom` and some other netty dependencies that are used explicitly; - `servicetalk-buffer-netty`: add missed `netty-common` dependency; - `servicetalk-transport-netty`: remove unused `netty-common` dependency; Result: Gradle generates valid pom.xml files.
colestanfield
approved these changes
Oct 15, 2024
daschl
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Maven helped to identify that after #3055 generated pom.xml files are invalid. We forgot to include
netty-bomin some modules that depend onio.nettywithout specifying netty version.Also, noticed that some of our modules that use
io.nettydo not list all used netty dependencies as needed.Modifications:
-nettyin their names add missednetty-bomand some other netty dependencies that are used explicitly;servicetalk-buffer-netty: add missednetty-commondependency;servicetalk-transport-netty: remove unusednetty-commondependency;Result:
Gradle generates valid pom.xml files.