traffic-resilience-http: extend connect timeout for CI #3077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The TrafficResilienceHttpServiceFilterTest.testStopAcceptingConnections test is flaky (see issue apple#3076) and it could be as simple as CI being slower than usual. Modifications: Extend the timeout for the CI environment to see if this fixes the flakiness.
tkountis
approved these changes
Oct 10, 2024
daschl
approved these changes
Oct 10, 2024
bryce-anderson
deleted the
bl_anderson/flaky-TrafficResilienceHttpServiceFilterTest
branch
idelpivnitskiy
added a commit
to idelpivnitskiy/servicetalk
that referenced
this pull request
Oct 15, 2024
Motivation: Even 4 seconds added in apple#3077 seems too low for CI. Trying higher value. Also, we can reuse already existing `CI` constant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The TrafficResilienceHttpServiceFilterTest.testStopAcceptingConnections test is flaky (see issue #3076) and it could be as simple as CI being slower than usual.
Modifications:
Extend the timeout for the CI environment to see if this fixes the flakiness.