Add SslConfig to onSecurityHandshake #3074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation ---------- This changeset adds ConnectionInfo if available to the onSecurityHandshake, similar to a change made to onTransportHandshakeComplete. This allows to get information about the SSL config from the argument, without having to get it as an instance variable from onTransportHandshakeComplete.
daschl
changed the title
servicetalk-transport-api/src/main/java/io/servicetalk/transport/api/ConnectionObserver.java
Show resolved
Hide resolved
...nal/src/main/java/io/servicetalk/transport/netty/internal/ConnectionObserverInitializer.java
Outdated
Show resolved
Hide resolved
idelpivnitskiy
approved these changes
Oct 3, 2024
...ty-internal/src/main/java/io/servicetalk/tcp/netty/internal/TcpClientChannelInitializer.java
Outdated
Show resolved
Hide resolved
...nal/src/main/java/io/servicetalk/transport/netty/internal/ConnectionObserverInitializer.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This changeset adds the
SslConfigif available to theonSecurityHandshake, similar to a change made toonTransportHandshakeCompletewhere the fullConnectionInfogets passed in. This allows to getinformation about the config from the argument itself, without having to get it as an instance variable
from
onTransportHandshakeComplete.