Add experimental system properties for Netty DnsNameResolver
#3073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Netty recently introduced 2 more DNS config options that help to workaround known infrastructure issues: - TCP fallback on timeout; - `DnsNameResolverChannelStrategy`; Modifications: Add 2 new experimental system properties: 1. `io.servicetalk.dns.discovery.netty.experimental.tcpFallbackOnTimeout` 2. `io.servicetalk.dns.discovery.netty.experimental.datagramChannelStrategy` Result: We can test these new features without commiting to them in our public API.
idelpivnitskiy
force-pushed
the
dns-props
branch
from
49cd605
to
1245e12
Compare
daschl
approved these changes
Oct 2, 2024
|
I validated that they are applied when required Netty version is in classpath. There is no easy way to validate that nothing breaks if older Netty version is in classpath. However, this use-case is rare and we can fix if there is a reported problem. |
bryce-anderson
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Netty recently introduced 2 more DNS config options that help to workaround known infrastructure issues:
DnsNameResolverChannelStrategy;Modifications:
Add 2 new experimental system properties:
io.servicetalk.dns.discovery.netty.experimental.tcpFallbackOnTimeoutio.servicetalk.dns.discovery.netty.experimental.datagramChannelStrategyResult:
We can test these new features without commiting to them in our public API.