http-netty: Fix flaky FullDuplexAndSequentialModeTest #3070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: This test suite has been flaky for a while. As detailed in issue apple#1894, this is because under some conditions the test running thread ends up waiting on a latch that it is actually responsible to release. Modifications: Make sure the publishing of the InputStreamPublisher happens in on a different thread so we don't end up in deadlock. Fixes apple#1894
daschl
reviewed
Sep 30, 2024
| CountDownLatch continueRequest, | ||
| InputStream payload) { | ||
| return connection.request(connection.post(SVC_ECHO).payloadBody(fromInputStream(payload, CHUNK_SIZE) | ||
| return connection.request(connection.post(SVC_ECHO).payloadBody(fromInputStream(payload, 1) |
There was a problem hiding this comment.
Why did the CHUNK_SIZE change from 1024 to 1 here?
There was a problem hiding this comment.
Because if it stays what it was the assertThrows(..) doesn't happen. I suspect we end up racing the cancellation in the separate thread.
There was a problem hiding this comment.
Now, knowing the reason, I'm agreed that smaller chunk makes it likely to happen we end up in a deadlock. For the original purpose of the test, it should not matter though. So, I don't mind if we change the size here or not.
idelpivnitskiy
approved these changes
Sep 30, 2024
servicetalk-http-netty/src/test/java/io/servicetalk/http/netty/AbstractNettyHttpServerTest.java
Outdated
Show resolved
Hide resolved
...talk-http-netty/src/test/java/io/servicetalk/http/netty/FullDuplexAndSequentialModeTest.java
Outdated
Show resolved
Hide resolved
|
CI failures are known flaky tests. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
This test suite has been flaky for a while. As detailed in issue #1894, this is because under some conditions the test running thread ends up waiting on a latch that it is actually responsible to release.
Modifications:
Make sure the publishing of the InputStreamPublisher happens in on a different thread so we don't end up in deadlock.
Fixes #1894