http-netty: Disable some GraceulConnectionClosureHandling tests #2827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The tests are super flaky making it almost impossible to get a clean CI run. The problem was in netty and has been fixed but we're waiting on a release. Modifications: - Disable the flaky tests and add some notes to the netty dependency
tkountis
approved these changes
Feb 7, 2024
bryce-anderson
deleted the
bl_anderson/disable_some_GracefulConnectionClosure_tests
branch
idelpivnitskiy
added a commit
to idelpivnitskiy/servicetalk
that referenced
this pull request
Feb 13, 2024
This reverts (apple#2827), commit db9a026. Resolves apple#2117.
idelpivnitskiy
added a commit
that referenced
this pull request
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The tests are super flaky making it almost impossible to get a clean CI run. The problem was in netty and has been fixed but we're waiting on a release.
Modifications:
Relates to #2117.