[Optional] Refactor diffusion.py for if not self.diffusion_config.no_use_residual:
#14
+17
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tolgacangoz
changed the title
diffusion.py for if not self.diffusion_config.no_use_residual:
tolgacangoz
commented
Sep 23, 2024
tolgacangoz
commented
Sep 27, 2024
| if len(x_t) == 3: | ||
| x_t, x_t_middle, x_t_low = x_t | ||
| pred, pred_middle, pred_low = p_t | ||
| pred_x0_previous, _ = self.sampler.get_x0_eps_from_pred(x_t_middle, pred_middle, times) |
There was a problem hiding this comment.
I might be wrong: Is using times correct here? This gives nan to me. When I change it with g_t[0][0, 0, 0, 0], it gives a good result at the 40. step, but it worsens towards the 50. step if 50 is the final.
tolgacangoz
changed the title
diffusion.py for if not self.diffusion_config.no_use_residual:Optional] Refactor diffusion.py for if not self.diffusion_config.no_use_residual:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is optional because I don't know if it is correct.
The pull request proposes refactoring the
diffusion.pyfile whenself.diffusion_config.no_use_residual=Falsefor nested models.@MultiPath @Shuangfei @luke-carlson