Fix module import 2 #737
Open
Fix module import 2 #737
+25
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These enhancements provide additional flexibility and options for implementing and experimenting with different recurrence methods in the Mamba and Jamba models, potentially improving performance and accuracy for various tasks.
- fixed functions redundant definitions - fixed Incorrect Module Import in layers.py
|
Thanks! @vishesh9131 you'll also need to bump aqt version in https://github.com/apple/axlearn/blob/2782df73b20eb55f218f501e5df4d0fe19f72227/pyproject.toml#L43C5-L43C18. After that I can trigger the PR checks. |
|
Hi @jiarui-lu2 , |
|
@jiarui-lu2 sorry for typo error... |
jiarui-lu2
approved these changes
Oct 11, 2024
|
@jiarui-lu2 |
|
As the CI states, looks like there are tests that requires fixing as well FAILED: /home/circleci/project/.pytype/pyi/axlearn/common/quantized_dot_general/utils_test.pyi
/home/circleci/.pyenv/versions/3.10.15/bin/python3.10 -m pytype.single --imports_info /home/circleci/project/.pytype/imports/axlearn.common.quantized_dot_general.utils_test.imports --module-name axlearn.common.quantized_dot_general.utils_test --platform linux -V 3.10 -o /home/circleci/project/.pytype/pyi/axlearn/common/quantized_dot_general/utils_test.pyi --analyze-annotated --nofail --quick /home/circleci/project/axlearn/common/quantized_dot_general/utils_test.py
File "/home/circleci/project/axlearn/common/quantized_dot_general/utils_test.py", line 8, in <module>: Can't find module 'aqt.jax.v2.int_numerics'. [import-error] |
- Check if cfg.fwd.lhs is of the expected type or has the expected attribute.
|
Hi @vishesh9131, you can view your CI logs in circleci, e.g.: https://app.circleci.com/pipelines/github/apple/axlearn/2776/workflows/84ee8526-8e05-4de1-ae48-8354f607af36/jobs/5975 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request: Fix Incorrect Module Import in
layers.pyNow axlearn supports python 3.10 thus the PR Is valid now.
Summary
This pull request addresses an issue with an incorrect module import in the
axlearn/common/quantized_dot_general/layers.pyfile. The import and usage of theContextclass from theaqt_dot_generalmodule have been corrected to use the appropriateContextclass from theaqt_utilsmodule.Changes
1. Import Correction:
Now axlearn supports python 3.10 thus the PR Is valid now.
aqt.jax.v2.aqt_dot_generaltoaqt.jax.v2.utilsand aliased it asaqt_utils.2. Context Class Usage:
Contextclass to useaqt_utils.Contextinstead ofaqt_dot_general.Context.New Changes (14Oct)
Explained:
NoNumericsfromaqt.jax.v2.config.IntNumericsfromaqt.jax.v2.int_numerics.int_numericsandno_numericsfromaqt.jax.v2.numerics.Testing
Additional Information
Code Changes
1. Importing aqt_utils
2. Taken Reference from the official README of aqt
to
Testing
AttributeErrorand the code runs successfully without any issues.my mail : [email protected]