Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimal Update to JWTKit 5 #68

Merged

Conversation

dimitribouniol
Copy link
Contributor

Based on #14, here is the minimal set of changes to move this over to JWTKit 5. As this library is likely blocking adoption for many upstream projects, I'm hoping this can accelerate the process before more full-fledged support can be added from #14.

Co-Authored-By: Tim Condon <[email protected]>
Co-Authored-By: Paul Toffoloni <[email protected]>
@dimitribouniol
Copy link
Contributor Author

If the main concern is changing the major version dependency from 4 to 5, vapor/jwt-kit#221 will help add additional support that this library in particular can use to remain backwards compatible with version 4 while also supporting 5.

Copy link
Collaborator

@alexanderjordanbaker alexanderjordanbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dimitribouniol Thank you for this submission, was waiting for a release with breaking changes to put this into, this looks good!

@dimitribouniol
Copy link
Contributor Author

Would finishing the compatibility update for jwt-kitv4 help get this in sooner then? This way it won’t require a release with breaking changes. If so, I can prioritize getting that finished this week.

@alexanderjordanbaker
Copy link
Collaborator

alexanderjordanbaker commented Feb 27, 2025

@dimitribouniol

error: Dependencies could not be resolved because 'jwt-kit' >= 5.0.0 contains incompatible tools version (6.0.0) and root depends on 'jwt-kit' 5.0.0..<6.0.0.

Looks like this is not possible on its own, it requires Swift 6

@dimitribouniol
Copy link
Contributor Author

dimitribouniol commented Feb 27, 2025

I’ll get that compatibility layer in then - this way we can keep the version locked to the latest v4 patch in Package.swift, and we can have a Package-swift6.0.swift that uses jwt-kit v4-5. I think that should cover all our bases?

(this code in the PR will incidentally stay the same since the compatibility layer adds the new v5 API surface to the v4 version branch)

@alexanderjordanbaker
Copy link
Collaborator

@dimitribouniol We are upgrading the library to Swift 6 as part of this breaking change, and after doing so tests are passing

@dimitribouniol
Copy link
Contributor Author

That works too haha

@dimitribouniol
Copy link
Contributor Author

While I have you re: breaking changes, this would also be a good one to consider addressing: #52

@alexanderjordanbaker
Copy link
Collaborator

It’s in my local branch already, just have to push it out

@alexanderjordanbaker alexanderjordanbaker merged commit 3174b58 into apple:main Feb 27, 2025
1 of 3 checks passed
@dimitribouniol dimitribouniol deleted the dimitri/jwkkit5-cleanup branch February 27, 2025 20:13
@dimitribouniol
Copy link
Contributor Author

Sweet, thanks for the updates!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants