Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): Remove Selenium.Support package as a dependency #843

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

nvborisenko
Copy link
Contributor

List of changes

  • Remove Selenium.Support package as a dependency

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change that adds functionality or value)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)
  • Test fix (non-breaking change that improves test stability or correctness)

Documentation

  • Have you proposed a file change/ PR with Appium to update documentation?

This can be done by navigating to the documentation section on http://appium.io selecting the appropriate command/endpoint and clicking the 'Edit this doc' link to update the C# example

Integration tests

  • Have you provided integration tests for your changes? (required for Bugfix, New feature, or Test fix)

Details

Seems this package is unnecessary.

Copy link

linux-foundation-easycla bot commented Oct 17, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

@Dor-bl Dor-bl changed the title Remove Selenium.Support package as a dependency build(deps): Remove Selenium.Support package as a dependency Oct 18, 2024
@Dor-bl
Copy link
Collaborator

Dor-bl commented Oct 18, 2024

@nvborisenko not sure why your existing signature don't hold here. Can you please re-sign?

@nvborisenko
Copy link
Contributor Author

Done.

@Dor-bl Dor-bl merged commit aa8f4f6 into appium:main Oct 18, 2024
3 checks passed
@Dor-bl Dor-bl added the Dependencies Pull requests that update a dependency file label Oct 18, 2024
@nvborisenko nvborisenko deleted the remove-selenium-support branch October 20, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants