Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING CHANGE: Remove obsolete TouchActions, MultiActions methods #832

Merged
merged 2 commits into from
Sep 25, 2024
Merged

BREAKING CHANGE: Remove obsolete TouchActions, MultiActions methods #832

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9bb7bbe
BREAKING CHANGE: Remove obsolete TouchActions, MultiActions methods
Dor-bl Sep 24, 2024
44f8b23
Merge branch 'main' into deprecate_touch_actions
KazuCocoa Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions src/Appium.Net/Appium/AppiumCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,15 +154,6 @@ public class AppiumCommand

#endregion Driver Commands

#region (Deprecated) Touch Commands
// TODO: Remove this region once we deprecate the touch actions
// Please use the W3C Actions instead.
new AppiumCommand(HttpCommandInfo.PostCommand, AppiumDriverCommand.PerformMultiAction,
"/session/{sessionId}/touch/multi/perform"),
new AppiumCommand(HttpCommandInfo.PostCommand, AppiumDriverCommand.PerformTouchAction,
"/session/{sessionId}/touch/perform"),

#endregion (Deprecated) Touch Commands

// Enable W3C Actions on AppiumWebDriver

Expand Down
22 changes: 1 addition & 21 deletions src/Appium.Net/Appium/AppiumDriver.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ public abstract class AppiumDriver : WebDriver,
IHasSessionDetails,
IHasLocation,
IHidesKeyboard, IInteractsWithFiles, IFindsByFluentSelector<AppiumElement>,
IInteractsWithApps, IPerformsTouchActions, IRotatable, IContextAware
IInteractsWithApps, IRotatable, IContextAware
{
private const string NativeApp = "NATIVE_APP";

Expand Down Expand Up @@ -386,26 +386,6 @@ public void DeactiveIMEEngine() =>

#endregion Input Method (IME)

#region (Deprecated) Multi Actions
// TODO: Remove this region once we deprecate the touch actions
// Please use the W3C Actions instead.
[Obsolete("Touch Actions are deprecated in W3C spec, please use W3C actions instead")]
public void PerformMultiAction(IMultiAction multiAction)
{
if (multiAction == null) return;
var parameters = multiAction.GetParameters();
Execute(AppiumDriverCommand.PerformMultiAction, parameters);
}
[Obsolete("Touch Actions are deprecated in W3C spec, please use W3C actions instead")]
public void PerformTouchAction(ITouchAction touchAction)
{
if (touchAction == null) return;
var parameters = AppiumCommandExecutionHelper.PrepareArgument("actions", touchAction.GetParameters());
Execute(AppiumDriverCommand.PerformTouchAction, parameters);
}

#endregion (Deprecated) Multi Actions

#region W3C Actions

// Replace or hide the original RemoteWebElement.PerformActions base method so that it does not require
Expand Down
16 changes: 0 additions & 16 deletions src/Appium.Net/Appium/AppiumDriverCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,22 +213,6 @@ public class AppiumDriverCommand

#endregion Appium Specific extensions to JSONWP Commands

#region (Deprecated) TouchActions
// TODO: Remove this region once we deprecate the touch actions
// Please use the W3C Actions instead.

/// <summary>
/// Perform touch action
/// </summary>
public const string PerformTouchAction = "performTouchAction";

/// <summary>
/// Perform multi touch action
/// </summary>
public const string PerformMultiAction = "performMultiTouch";

#endregion (Deprecated) MultiTouchActions

#region W3C Actions

/// <summary>
Expand Down
38 changes: 0 additions & 38 deletions src/Appium.Net/Appium/Interfaces/IPerformsTouchActions.cs
View file
Open in desktop

This file was deleted.

98 changes: 0 additions & 98 deletions src/Appium.Net/Appium/MultiAction/MultiAction.cs
View file
Open in desktop

This file was deleted.

Loading