Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add summary comment for test prerequisite #715

Merged
merged 3 commits into from
Dec 24, 2023
Merged

Conversation

Dor-bl
Copy link
Collaborator

@Dor-bl Dor-bl commented Dec 23, 2023

List of changes

Added summary comment that explains the prerequisite for the test to pass. The comment indicates that the Appium server needs to be run with a specific command (appium --allow-insecure get_server_logs). The test method (CanCaptureServerTest) then checks various conditions related to server logs using assertions.

Types of changes

What types of changes are you proposing/introducing to the .NET client?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • New feature (non-breaking change which adds value to the project)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)

Documentation

  • Have you proposed a file change/ PR with appium to update documentation?

This can be done by navigating to the documentation section on http://appium.io selecting the appropriate command/endpoint and clicking the 'Edit this doc' link to update the C# example

Integration tests

  • Have you provided integration tests to pass against the beta version of appium? (for Bugfix or New feature)

Details

Please provide more details about changes if it is necessary. If there are new features you can provide code samples showing how they work and possible use cases. Also, you can create gists with pasted C# code samples or put them here using markdown.
About markdown please read Mastering markdown and Writing on GitHub

@github-actions github-actions bot added the Test label Dec 23, 2023
@Dor-bl Dor-bl merged commit a2b7e42 into appium:main Dec 24, 2023
3 checks passed
@Dor-bl Dor-bl deleted the logTest branch December 24, 2023 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants