fix: device system time null exception (#448)

closes #440
appium · Jan 14, 2021 · a048964 · a048964
1 parent e75c1eb
commit a048964
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 7 deletions.
diff --git a/src/Appium.Net/Appium.Net.csproj b/src/Appium.Net/Appium.Net.csproj
@@ -4,12 +4,10 @@
     <TargetFrameworks>netstandard2.0;net45</TargetFrameworks>
     <PackageLicenseFile>LICENSE.txt</PackageLicenseFile>
     <RootNamespace>OpenQA.Selenium</RootNamespace>
-    <AssemblyVersion>4.2.0</AssemblyVersion>
-    <Version>4.2.0</Version>
     <Company>Appium Commiters</Company>
     <Product>Appium-Dotnet-Driver</Product>
     <PackageRequireLicenseAcceptance>false</PackageRequireLicenseAcceptance>
-    <GeneratePackageOnBuild>true</GeneratePackageOnBuild>
+    <GeneratePackageOnBuild>false</GeneratePackageOnBuild>
     <Copyright>Copyright © 2020</Copyright>
     <PackageProjectUrl>https://github.com/appium/appium-dotnet-driver</PackageProjectUrl>
     <RepositoryUrl>https://github.com/appium/appium-dotnet-driver</RepositoryUrl>
@@ -26,7 +24,6 @@
 
   <PropertyGroup>
     <PackageLicenseFile>LICENSE.txt</PackageLicenseFile>
-    <FileVersion>4.2.0</FileVersion>
   </PropertyGroup>
 
   <PropertyGroup Condition="'$(Configuration)|$(TargetFramework)|$(Platform)'=='Release|netstandard2.0|AnyCPU'">

diff --git a/src/Appium.Net/Appium/AppiumDriverCommand.cs b/src/Appium.Net/Appium/AppiumDriverCommand.cs
@@ -201,7 +201,7 @@ public class AppiumDriverCommand
         /// <summary>
         /// Get the time on the device
         /// </summary>
-        public const string SystemTime = "system_time";
+        public const string SystemTime = "getDeviceTime";
 
         /// <summary>
         /// Get Display Density

diff --git a/test/integration/Android/EmulatorDeviceTime.cs b/test/integration/Android/EmulatorDeviceTime.cs
@@ -3,6 +3,7 @@
 using NUnit.Framework;
 using OpenQA.Selenium.Appium;
 using OpenQA.Selenium.Appium.Android;
+using static System.String;
 
 namespace Appium.Net.Integration.Tests.Android
 {
@@ -35,8 +36,13 @@ public void AfterEach()
         public void DeviceTimeTest()
         {
             var time = _driver.DeviceTime;
-            Console.WriteLine(time);
-            Assert.AreEqual(true, time.Length == 28);
+            Assert.Multiple(() =>
+            {
+                Assert.NotNull(time);
+                Assert.AreNotEqual(Empty, time);
+                Console.WriteLine(time);
+                Assert.NotNull(DateTime.Parse(time));
+            });
         }
     }
 }