fix: Make 'executable' opt optional (#726)

appium · Apr 1, 2024 · e213744 · e213744
1 parent a708640
commit e213744
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/lib/adb.ts b/lib/adb.ts
@@ -40,8 +40,8 @@ export class ADB {
     const options: ADBOptions = _.defaultsDeep(opts, _.cloneDeep(DEFAULT_OPTS));
     _.defaultsDeep(this, options);
 
-    // avoid TS error by explicitly assigning
-    this.executable = options.executable;
+    // The above defaultsDeep call guarantees the 'executable' field to be always assigned
+    this.executable = options.executable as ADBExecutable;
 
     if (options.remoteAdbHost) {
       this.executable.defaultArgs.push('-H', options.remoteAdbHost);

diff --git a/lib/options.ts b/lib/options.ts
@@ -11,7 +11,7 @@ export interface ADBOptions {
   keystorePassword?: string;
   keyAlias?: string;
   keyPassword?: string;
-  executable: ADBExecutable;
+  executable?: ADBExecutable;
   tmpDir?: string;
   curDeviceId?: string;
   emulatorPort?: number;