This repository was archived by the owner on Aug 14, 2020. It is now read-only.
backend/repository2: don't ignore when there's an image digest #171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code for pulling from a v2 repository always used the tag to pull, but the correct action was to pull by digest when one was specified.
|
lgtm, can we test? |
|
afaik there are no tests for fetching from a remote repository, by digest or not. I just created this to reflect this fact: #172. |
|
Bump on this, it's necessary for rkt/rkt#2188. I also need tests for fetching for #176, and whatever tests I add there could reasonably cover this use case. |
|
Let's merge this then. LGTM. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code for pulling from a v2 repository always used the tag to pull,
but the correct action was to pull by digest when one was specified.
Related: #170.