Fikser tildeling av samme rom ved parallelle intervjuer #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: @sindremil
Co-Authored-By: @sindremil
Co-Authored-By: @sindremil
Co-Authored-By: @sindremil
4 tasks
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hvordan vil output fra algoritmen se ut nå? |
fredrir
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fikser tildeling av samme rom ved parallelle intervju og gjør samtidig litt refaktorering av koden.
Det har gjort kjøretiden merkbart høyere (bruker nå drøyt to minutter på å kjøre enhetstestene), så vi bør kanskje se på hvordan vi kan kutte ned kjøretiden. I praktiske tilfeller vil nok ikke kjøretiden øke så veldig mye, da de testene som nå bruker lengst tid har et ikke-realistisk antall parallelle intervjuer. Samtidig så kjøres jo intervjutildelingen bare én gang per opptak, så det bør ikke være krise om det tar et halvt minutt.
Closes #314, #305