-
Notifications
You must be signed in to change notification settings - Fork 20
Conversation
Codecov Report
@@ Coverage Diff @@
## master #118 +/- ##
============================================
+ Coverage 73.50% 73.75% +0.24%
- Complexity 847 854 +7
============================================
Files 100 100
Lines 3216 3227 +11
Branches 351 356 +5
============================================
+ Hits 2364 2380 +16
+ Misses 690 685 -5
Partials 162 162
Continue to review full report at Codecov.
|
2ccc67f
to
9077f4f
Compare
3e0b1e1
to
8d779c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a typo to be fixed
@@ -84,7 +84,12 @@ In one execution, LicenseScout can either scan for Java artifacts or for Javascr | |||
|
|||
=== Scan Location | |||
|
|||
The base directory where archives are searched for (recursively and also inside JARs) is configured by the parameter `scanDirectory`. | |||
The location to b scanned can either be: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo on "to be"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
8d779c7
to
77cab74
Compare
- documentation update
- added integration test cases - renamed integration test cases - updated documentation
77cab74
to
9031c69
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Type of request
Related Issue(s)
Solves #108
Concept
Description of the change
Description of current state
Description of target state
Estimated investment / approximate investment
Initiator
Matthias Pfisterer
Technical information
Platform / target area
known side-effects
other
DB Changes (if so: incl. scripts with definitions and testdata)
How has this Tested?
Added integration tests using parameter 'scanArtifacts'. Executed all xisting tests.
Screenshots, Uploads, other documents (if appropriate):
Checklist: