Skip to content
This repository has been archived by the owner on Dec 20, 2022. It is now read-only.

Enabling Maven scan mode #118

Merged
merged 2 commits into from
Mar 27, 2020
Merged

Conversation

pfistererm
Copy link
Contributor

@pfistererm pfistererm commented Mar 7, 2020

  • changed to actually using ScanLocation's list of files if present
  • added integration tests using the new configuration
  • documentation update

Type of request

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring
  • Documentation or documentation changes

Related Issue(s)

Solves #108

Concept

Description of the change

Description of current state

Description of target state

Estimated investment / approximate investment

Initiator

Matthias Pfisterer

Technical information

Platform / target area

known side-effects

other

DB Changes (if so: incl. scripts with definitions and testdata)

How has this Tested?

Added integration tests using parameter 'scanArtifacts'. Executed all xisting tests.

Screenshots, Uploads, other documents (if appropriate):

Checklist:

  • All the commits are signed.
  • My code follows the code style of this project.
  • I agree with die CLA.
  • I have read the CONTRIBUTING docs.
  • I have added/updated necessary documentation (if appropriate).

@codecov
Copy link

codecov bot commented Mar 7, 2020

Codecov Report

Merging #118 into master will increase coverage by 0.24%.
The diff coverage is 96.42%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #118      +/-   ##
============================================
+ Coverage     73.50%   73.75%   +0.24%     
- Complexity      847      854       +7     
============================================
  Files           100      100              
  Lines          3216     3227      +11     
  Branches        351      356       +5     
============================================
+ Hits           2364     2380      +16     
+ Misses          690      685       -5     
  Partials        162      162              
Impacted Files Coverage Δ Complexity Δ
...in/licensescout/execution/ExecutionParameters.java 84.09% <ø> (ø) 51.00 <0.00> (ø)
...n/licensescout/report/mojo/AbstractReportMojo.java 1.36% <ø> (ø) 1.00 <0.00> (ø)
...va/org/aposin/licensescout/execution/Executor.java 77.13% <92.85%> (+0.18%) 70.00 <5.00> (+2.00)
...icensescout/exporter/AbstractVelocityExporter.java 97.95% <100.00%> (+0.04%) 10.00 <0.00> (+1.00)
...org/aposin/licensescout/finder/AbstractFinder.java 97.56% <100.00%> (+0.06%) 18.00 <1.00> (+1.00)
.../org/aposin/licensescout/finder/JavaJarFinder.java 91.50% <100.00%> (+4.97%) 26.00 <3.00> (+2.00)
...rg/aposin/licensescout/execution/ScanLocation.java 87.50% <0.00%> (+6.25%) 7.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b716233...9031c69. Read the comment docs.

@pfistererm pfistererm force-pushed the mp_maven_scan_mode4 branch from 2ccc67f to 9077f4f Compare March 7, 2020 14:41
@pfistererm pfistererm marked this pull request as ready for review March 7, 2020 21:18
@pfistererm pfistererm requested a review from davu-all March 7, 2020 23:06
@pfistererm pfistererm force-pushed the mp_maven_scan_mode4 branch from 3e0b1e1 to 8d779c7 Compare March 8, 2020 17:19
Copy link
Collaborator

@davu-all davu-all left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a typo to be fixed

@@ -84,7 +84,12 @@ In one execution, LicenseScout can either scan for Java artifacts or for Javascr

=== Scan Location

The base directory where archives are searched for (recursively and also inside JARs) is configured by the parameter `scanDirectory`.
The location to b scanned can either be:
Copy link
Collaborator

@davu-all davu-all Mar 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo on "to be"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@pfistererm pfistererm force-pushed the mp_maven_scan_mode4 branch from 8d779c7 to 77cab74 Compare March 27, 2020 01:16
- added integration test cases
- renamed integration test cases
- updated documentation
@pfistererm pfistererm force-pushed the mp_maven_scan_mode4 branch from 77cab74 to 9031c69 Compare March 27, 2020 01:19
@pfistererm pfistererm requested a review from davu-all March 27, 2020 01:20
Copy link
Collaborator

@davu-all davu-all left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pfistererm pfistererm merged commit 616ab09 into aposin:master Mar 27, 2020
@pfistererm pfistererm deleted the mp_maven_scan_mode4 branch March 27, 2020 18:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants