Fix macOS CI #2238
Merged
Fix macOS CI #2238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Further ensure the smoke tests compile on the same same major version.
✅ Docs Preview ReadyNo new or changed pages found. |
jonathanrainer
force-pushed
the
jr/fix-mac-ci
branch
2 times, most recently
from
3053154
to
257f55e
Compare
This seems to be a relic from when M1 builds were new and consequently less well-supported. Going to attempt to go to latest now and see if our CI is amenable.
loshz
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2237
CI has been broken for Mac since Homebrew pulled support for OpenSSL at the specific version we're requiring. However this appears to be a holdover from older versions of MacOS where Rosetta etc. were less well supported, so in moving this forward we should be able to upgrade as well.
Green Smoke Test run: https://github.com/apollographql/rover/actions/runs/11515349122/job/32056173251