Consolidate Rover Tests #2095
Open
Consolidate Rover Tests #2095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanrainer
force-pushed
the
jr/test-consolidation
branch
6 times, most recently
from
b2ef38b
to
1ec996b
Compare
jonathanrainer
force-pushed
the
jr/test-consolidation
branch
from
1ec996b
to
87ca43b
Compare
✅ Docs Preview ReadyNo new or changed pages found. |
aaronArinder
approved these changes
Nov 7, 2024
This stops us running the flyby integration tests and `supergraph-demo` and removes the corresponding parts of xtask
This should make it clearer where pieces fit
Also remove old examples we now don't need
Add concurrency clause as well so lots of runs don't build up
jonathanrainer
force-pushed
the
jr/test-consolidation
branch
from
8fb43b5
to
cb6aa54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enacts the behaviour as previously discussed (see associated Slack post for proposal), to consolidate our testing story and include the E2E tests on each PR. I've also tided up a lot of the repo and got rid of a lot of cruft that was being introduced in order to keep running some older test suites.
A lot of the changes in this are just deleting old code and the testing is running it on this PR so it should all work/make sense though happy to chat it through if people are interested