Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor integration tests #6015

Merged
merged 5 commits into from
Sep 27, 2024
Merged

refactor integration tests #6015

merged 5 commits into from
Sep 27, 2024

Conversation

Geal
Copy link
Contributor

@Geal Geal commented Sep 17, 2024

When testing #6000 I had issues with how subgraph mocks creation is happening in 3 different places. To avoid further issues, this factors them in one function


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Tests added and passing3
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

@Geal Geal requested review from a team as code owners September 17, 2024 13:34
Copy link
Contributor

@Geal, please consider creating a changeset entry in /.changesets/. These instructions describe the process and tooling.

@Geal Geal enabled auto-merge (squash) September 27, 2024 09:48
@Geal Geal merged commit 03a743e into dev Sep 27, 2024
12 of 13 checks passed
@Geal Geal deleted the geal/refactor-integration-tests branch September 27, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants