Skip to content

Commit

Permalink
docs: Remove superfluous step from RELEASE_CHECKLIST.md (#5981)
Browse files Browse the repository at this point in the history
  • Loading branch information
abernix authored Sep 16, 2024
1 parent b85aaa2 commit 30f3004
Showing 1 changed file with 2 additions and 8 deletions.
10 changes: 2 additions & 8 deletions RELEASE_CHECKLIST.md
Original file line number Diff line number Diff line change
Expand Up @@ -189,13 +189,7 @@ Start following the steps below to start a release PR. The process is **not ful
git commit -m "prep release: v${APOLLO_ROUTER_RELEASE_VERSION}${APOLLO_ROUTER_PRERELEASE_SUFFIX}"
```

9. Push this commit up to the existing release PR:

```
git push "${APOLLO_ROUTER_RELEASE_GIT_ORIGIN}" "${APOLLO_ROUTER_RELEASE_VERSION}"
```

10. Git tag the current commit and & push the branch and the pre-release tag simultaneously:
9. Git tag the current commit and & push the branch and the pre-release tag simultaneously:

This process will kick off the bulk of the release process on CircleCI, including building each architecture on its own infrastructure and notarizing the macOS binary.

Expand All @@ -204,7 +198,7 @@ Start following the steps below to start a release PR. The process is **not ful
git push "${APOLLO_ROUTER_RELEASE_GIT_ORIGIN}" "${APOLLO_ROUTER_RELEASE_VERSION}" "v${APOLLO_ROUTER_RELEASE_VERSION}${APOLLO_ROUTER_PRERELEASE_SUFFIX}"
```

11. Finally, publish the Crates from your local computer (this also needs to be moved to CI, but requires changing the release containers to be Rust-enabled and to restore the caches):
10. Finally, publish the Crates from your local computer (this also needs to be moved to CI, but requires changing the release containers to be Rust-enabled and to restore the caches):

> Note: This command may appear unnecessarily specific, but it will help avoid publishing a version to Crates.io that doesn't match what you're currently releasing. (e.g., in the event that you've changed branches in another window)
Expand Down

0 comments on commit 30f3004

Please sign in to comment.