Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query-graph): allow multiple best path options per subgraph #3177

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

duckki
Copy link
Contributor

@duckki duckki commented Oct 28, 2024

It's necessary when advancing to a subgraph with multiple overlapping @interfaceObject implementations.

- when advancing to a subgraph with multiple overlapping @interfaceObject implementations
@svc-apollo-docs
Copy link
Collaborator

svc-apollo-docs commented Oct 28, 2024

✅ Docs Preview Ready

Configuration
{
  "repoOverrides": {
    "apollographql/federation@main": {
      "remote": {
        "owner": "apollographql",
        "repo": "federation",
        "branch": "fed-393"
      }
    }
  }
}
Name Link

Commit

61605ba

Preview

https://www.apollographql.com/docs/deploy-preview/7dffd783a80a2d56b20a

Build ID

7dffd783a80a2d56b20a

File Changes

0 new, 1 changed, 0 removed
* graphos/schema-design/guides/handling-n-plus-one.mdx

Pages

1


1 pages published. Build will be available for 30 days.

Copy link

changeset-bot bot commented Oct 28, 2024

⚠️ No Changeset found

Latest commit: 61605ba

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Oct 28, 2024

Deploy Preview for apollo-federation-docs canceled.

Name Link
🔨 Latest commit 61605ba
🔍 Latest deploy log https://app.netlify.com/sites/apollo-federation-docs/deploys/671fe8fcb7b334000843e2f9

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@duckki duckki changed the title fix: keep multiple best path options per subgraph fix: allow multiple best path options per subgraph Oct 28, 2024
@duckki duckki changed the title fix: allow multiple best path options per subgraph fix(query-graph): allow multiple best path options per subgraph Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants