apollo-federation-types: merge routing_url in SupergraphConfig::merge_subgraphs
#574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e_subgraphs` This function was added a few months ago in #541 and as far as I know is only used in Rover for the `supergraph compose` and `dev` commands to combine configuration from `--graph-ref` and `--supergraph-config`/`--config` (and the feature does not actually work for `supergraph compose` due to the issue fixed in apollographql/rover#2101). The use case here is to let you run composition or dev against a GraphOS graph with some local changes, and so "I just want to change the SDL and nothing else" is a reasonable use case. This change means that if an override specifies SDL but no routing URL for a subgraph, Rover will continue to use the routing URL fetched from GraphOS for that subgraph, which seems reasonable. While this is a "backwards incompatible" change, this crate is only intended for use by the Rover CLI and in the one case where this was called (`rover dev --graph-ref REF --supergraph-config CONFIG`) this seems like a clear improvement.
benjamn
approved these changes
Sep 6, 2024
tninesling
approved these changes
Sep 6, 2024
glasser
added a commit
to apollographql/rover
that referenced
this pull request
Sep 6, 2024
This pulls in apollographql/federation-rs#574 which improves the logic used to merge remote and local config such that if your local config does not specify a `routing_url` for a subgraph that also exists in the remote config, the remote config's URL is used instead of deleting it. Update the docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function was added a few months ago in #541 and as far as I know is only used in Rover for the
supergraph composeanddevcommands to combine configuration from--graph-refand--supergraph-config/--config(and the feature does not actually work forsupergraph composedue to the issue fixed in apollographql/rover#2101).The use case here is to let you run composition or dev against a GraphOS graph with some local changes, and so "I just want to change the SDL and nothing else" is a reasonable use case. This change means that if an override specifies SDL but no routing URL for a subgraph, Rover will continue to use the routing URL fetched from GraphOS for that subgraph, which seems reasonable.
While this is a "backwards incompatible" change, this crate is only intended for use by the Rover CLI and in the one case where this was called (
rover dev --graph-ref REF --supergraph-config CONFIG) this seems like a clear improvement.