Try to use the GraphQLError class to produce the error #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't address the root cause of an unexpected error, but it makes the transtion of the error back through the router a little cleaner.
By looking up how typescript works in google and attempting to write some.
Signed-off-by: Benjamin Coenen <[email protected]>
Signed-off-by: Benjamin Coenen <[email protected]>
…rypen/1519-slghtly-better-errors
Signed-off-by: Benjamin Coenen <[email protected]>
Signed-off-by: Benjamin Coenen <[email protected]>
Signed-off-by: Benjamin Coenen <[email protected]>
abernix
commented
Sep 9, 2022
| @@ -215,18 +214,17 @@ async function run() { | |||
| }); | |||
| } | |||
| } catch (e) { | |||
| logger.warn(`plan_worker: an unknown error occured ${e}\n`); | |||
| logger.warn(`plan_worker: an unknown error occurred ${e}\n`); | |||
|
I already tried, it produces a bad bundle.js with require inside and deno is unable to launch with |
Yeah, I know. I wanted to see why. We already use |
|
I am concerned this doesn't work and I'm going to leave this PR open for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just to test this approach