Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate @nonnull #6152

Merged
merged 4 commits into from
Sep 18, 2024
Merged

Deprecate @nonnull #6152

merged 4 commits into from
Sep 18, 2024

Conversation

martinbonnin
Copy link
Contributor

Using @nonnull now yields:

> Task :integration-tests:generateNonnull-kotlinApolloSources
w: /Users/martinbonnin/git/apollo-kotlin/tests/integration-tests/src/commonTest/kotlin/test/nonnull/graphql/extra.graphqls: (1, 19): 
Apollo: Using `@nonnull` is deprecated. Use `@semanticNonNull` and/or `@catch` instead. See https://go.apollo.dev/ak-nullability.
w: /Users/martinbonnin/git/apollo-kotlin/tests/integration-tests/src/commonTest/kotlin/test/nonnull/graphql/operations.graphql: (3, 12): 
Apollo: Using `@nonnull` is deprecated. Use `@semanticNonNull` and/or `@catch` instead. See https://go.apollo.dev/ak-nullability.

Closes #5409

@martinbonnin martinbonnin requested review from a team and BoD as code owners September 18, 2024 10:05
Copy link

netlify bot commented Sep 18, 2024

Deploy Preview for apollo-android-docs canceled.

Name Link
🔨 Latest commit 9fea0b9
🔍 Latest deploy log https://app.netlify.com/sites/apollo-android-docs/deploys/66eab9bf56da5200086a7c2d

@martinbonnin
Copy link
Contributor Author

@BoD the intelli plugin fails on ApolloClientDirectiveStripperTest

     Actual [[query MyQuery { 
      person { 
        identity { 
          firstName @catch 
          lastName 
        } 
      } 
    } 
    ]] 
    Expected [[query MyQuery { 
      person { 
        identity { 
          firstName 
          lastName 
        } 
      } 
    } 
    ]] 

Do we need to add @catch to a list somewhere?

@martinbonnin
Copy link
Contributor Author

@BoD the intelli plugin fails on ApolloClientDirectiveStripperTest

Ah, I think I found it, need to import the directive, trying it out...

Copy link
Contributor

@BoD BoD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@martinbonnin martinbonnin merged commit 8e14023 into main Sep 18, 2024
9 checks passed
@martinbonnin martinbonnin deleted the deprecate-nonnull branch September 18, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate @nonnull
2 participants