Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test: remove flake #5167

Merged
merged 2 commits into from
Aug 16, 2023
Merged

Test: remove flake #5167

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a2c7d7
Speed up tests
martinbonnin Aug 8, 2023
ddcde21
revert native-benchmarks
martinbonnin Aug 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 8 additions & 14 deletions tests/integration-tests/src/appleTest/kotlin/test/HttpEngineTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,8 @@ import com.apollographql.apollo3.mpp.currentTimeMillis
import com.apollographql.apollo3.network.http.DefaultHttpEngine
import com.apollographql.apollo3.network.http.get
import com.apollographql.apollo3.testing.internal.runTest
import platform.CFNetwork.kCFErrorDomainCFNetwork
import platform.CFNetwork.kCFErrorHTTPSProxyConnectionFailure
import platform.Foundation.CFBridgingRelease
import platform.Foundation.NSError
import platform.Foundation.NSURLErrorCannotFindHost
import platform.Foundation.NSURLErrorCannotConnectToHost
import platform.Foundation.NSURLErrorDomain
import platform.Foundation.NSURLErrorTimedOut
import kotlin.test.Test
Expand All @@ -26,7 +23,11 @@ import kotlin.test.fail
class HttpEngineTest {
@Test
fun canReadNSError() = runTest {
val apolloClient = ApolloClient.Builder().serverUrl("https://inexistent.host/graphql").build()
/**
* Try to trigger an error wihtout having to wait 60s on a timeout.
* Hopefully Port 1 is closed on most machines. If that's not enough, we'd need to find an instrumented server
*/
val apolloClient = ApolloClient.Builder().serverUrl("https://127.0.0.1:1/graphql").build()

val response = apolloClient.query(HeroNameQuery()).execute()
val apolloNetworkException = response.exception
Expand All @@ -38,15 +39,8 @@ class HttpEngineTest {
// assertIs<NSError>(cause)
check(cause is NSError)

assertTrue(
when {
// Happens locally if a proxy is running
cause.domain == (CFBridgingRelease(kCFErrorDomainCFNetwork) as String) && cause.code == kCFErrorHTTPSProxyConnectionFailure.toLong() -> true
// Default case
cause.domain == NSURLErrorDomain && cause.code == NSURLErrorCannotFindHost -> true
else -> false
}
)
assertEquals(cause.domain, NSURLErrorDomain)
assertEquals(cause.code, NSURLErrorCannotConnectToHost)
}

@Test
Expand Down
Loading