Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use compilations instead of multiple mpp targets for java codegen tests #5164

Merged
merged 3 commits into from
Aug 16, 2023

Conversation

martinbonnin
Copy link
Contributor

Inspired from https://youtrack.jetbrains.com/issue/KT-61007

This introduces an intermediate kotlinCodegenTest source set that is common to everything except javaCodegen. Our sourceSet graph for tests is now like this:

mermaid-diagram-2023-08-07-195957

@martinbonnin martinbonnin requested a review from BoD as a code owner August 7, 2023 18:02
@netlify
Copy link

netlify bot commented Aug 7, 2023

Deploy Preview for apollo-android-docs canceled.

Name Link
🔨 Latest commit 99910be
🔍 Latest deploy log https://app.netlify.com/sites/apollo-android-docs/deploys/64dc9b7de21bc500086bb487

Copy link
Contributor

@BoD BoD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! 🎉

@martinbonnin martinbonnin marked this pull request as draft August 9, 2023 10:51
@martinbonnin martinbonnin changed the base branch from main to count-tests August 11, 2023 10:09
@martinbonnin
Copy link
Contributor Author

martinbonnin commented Aug 11, 2023

Build scans

There were more native tasks executed here, will dig into it

Base automatically changed from count-tests to main August 16, 2023 09:19
@martinbonnin martinbonnin marked this pull request as ready for review August 16, 2023 09:49
@martinbonnin
Copy link
Contributor Author

We used to add targets for both macosArm64 and macosX64 while tests were running only on one of those (but compilation can be run for both). By only adding the host target, we should save a bit of time.

@martinbonnin
Copy link
Contributor Author

1131 tests executed

macosX64 tests are executed here

Merging this.

@martinbonnin martinbonnin merged commit 5ab77cb into main Aug 16, 2023
8 checks passed
@martinbonnin martinbonnin deleted the compilations branch August 16, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants