Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a test for field names that have the same name as an enum type #5158

Merged
merged 2 commits into from
Aug 7, 2023
Merged

Add a test for field names that have the same name as an enum type #5158

merged 2 commits into from
Aug 7, 2023

Conversation

martinbonnin
Copy link
Contributor

Another low hanging fruit
Closes #1156

@martinbonnin martinbonnin requested a review from BoD as a code owner August 4, 2023 18:02
@netlify
Copy link

netlify bot commented Aug 4, 2023 •
edited
Loading

✅ Deploy Preview for apollo-android-docs canceled.

Name Link
🔨 Latest commit 047282d
🔍 Latest deploy log https://app.netlify.com/sites/apollo-android-docs/deploys/64d0dcda7c3f68000875de51

BoD
BoD approved these changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@BoD BoD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@martinbonnin martinbonnin merged commit 3cc883c into main Aug 7, 2023
8 checks passed
@martinbonnin martinbonnin deleted the add-another-test branch August 7, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BoD BoD BoD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Similarly named properties result in wrong object used in generated code
2 participants
@martinbonnin @BoD